Hi,
On 07/09/2017 23:41, Ni, Ruiyu wrote:
Paulo,
Did you mix the usage of "\r\n" and "\n"? because I saw a ^M in your diff.
However, the diff content looks good to me.
No, I didn't. My local repo just lacked the 'git config core.whitespace
cr-at-eol' setting so 'git diff' showed the CRLFs as whitespace errors.
Just ignore them :-)
Thanks!
Paulo
Thanks/Ray
-----Original Message-----
From: Paulo Alcantara [mailto:pca...@zytor.com]
Sent: Friday, September 8, 2017 8:56 AM
To: edk2-devel@lists.01.org
Cc: Laszlo Ersek <ler...@redhat.com>; Justen, Jordan L
<jordan.l.jus...@intel.com>; Andrew Fish <af...@apple.com>; Kinney,
Michael D <michael.d.kin...@intel.com>; Gao, Liming
<liming....@intel.com>; Zeng, Star <star.z...@intel.com>; Dong, Eric
<eric.d...@intel.com>; Doran, Mark <mark.do...@intel.com>; Ni, Ruiyu
<ruiyu...@intel.com>; Wu, Hao A <hao.a...@intel.com>
Subject: Re: [PATCH v5 0/6] read-only UDF file system support
Ray,
On 07/09/2017 20:13, Paulo Alcantara wrote:
v5:
- Fixed OVMF IA32 build.
- Fixed a typo in UdfDriveBindingStop() ("This" -> "SimpleFs") which
broke retrieval of private fs data from SimpleFs protocol --
identified by 'reconnect -r' command in UEFI shell.
Follow the diff between v4 and v5 for Mde*Pkg changes (forgot to include it
when resending):
diff --git a/MdeModulePkg/Universal/Disk/UdfDxe/File.c
b/MdeModulePkg/Universal/Disk/UdfDxe/File.c
index 8ad14fe594..2dbcff0be4 100644
--- a/MdeModulePkg/Universal/Disk/UdfDxe/File.c
+++ b/MdeModulePkg/Universal/Disk/UdfDxe/File.c
@@ -372,7 +372,7 @@ UdfRead (
PrivFileData->FileSize,
&PrivFileData->FilePosition,
Buffer,
- BufferSize
+ (UINT64 *)(UINTN)BufferSize^M
);
} else if (IS_FID_DIRECTORY_FILE (Parent->FileIdentifierDesc)) {
if (ReadDirInfo->FidOffset == 0 && PrivFileData->FilePosition > 0) {
diff --
git a/MdeModulePkg/Universal/Disk/UdfDxe/Udf.c
b/MdeModulePkg/Universal/Disk/UdfDxe/Udf.c
index 9f10c78ca9..49dc7077b7 100644
--- a/MdeModulePkg/Universal/Disk/UdfDxe/Udf.c
+++ b/MdeModulePkg/Universal/Disk/UdfDxe/Udf.c
@@ -264,7 +264,7 @@ UdfDriverBindingStop (
EFI_OPEN_PROTOCOL_GET_PROTOCOL
);
if (!EFI_ERROR (Status)) {
- PrivFsData = PRIVATE_UDF_SIMPLE_FS_DATA_FROM_THIS (This);
+ PrivFsData = PRIVATE_UDF_SIMPLE_FS_DATA_FROM_THIS
(SimpleFs);^M
//
// Uninstall child handle
Thanks,
Paulo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
