Per the UEFI Spec, GetBarAttributes() should return the Host address. But current implementation returns the address read from the BAR, which is the Device address. Per the description of AddressTranslationOffset in ACPI spec: "For bridges that translate addresses across the bridge, this is the offset that must be added to the address on the secondary side to obtain the address on the primary side." HostAddress = DeviceAddress + AddressTranslationOffset.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni <[email protected]> Cc: Ard Biesheuvel <[email protected]> Cc: Benjamin Herrenschmidt <[email protected]> Cc: Andrew Fish <[email protected]> Cc: Dong Wei <[email protected]> Cc: Laszlo Ersek <[email protected]> Cc: Bartosz Szczepanek <[email protected]> --- MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c index cc7125e4fc..852d35d710 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c @@ -1955,7 +1955,7 @@ PciIoGetBarAttributes ( End->Checksum = 0; // - // Get the Address Translation Offset + // Get the Address Translation Offset and convert the Device address to Host address. // if (Descriptor->ResType == ACPI_ADDRESS_SPACE_TYPE_MEM) { Descriptor->AddrTranslationOffset = GetMmioAddressTranslationOffset ( @@ -1967,6 +1967,7 @@ PciIoGetBarAttributes ( FreePool (Descriptor); return EFI_UNSUPPORTED; } + Descriptor->AddrRangeMin += Descriptor->AddrTranslationOffset; } } -- 2.12.2.windows.2 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
