I do not understand the context of the code. The change is good to fix the build failure, but I want to ask a question before I gave Rb. :)
Is it possible ReadFileInfo->FilePosition less than FilePosition? Thanks, Star -----Original Message----- From: Paulo Alcantara [mailto:[email protected]] Sent: Wednesday, September 13, 2017 12:45 PM To: [email protected] Cc: Paulo Alcantara <[email protected]>; Zeng, Star <[email protected]>; Dong, Eric <[email protected]>; Ni, Ruiyu <[email protected]>; Bi, Dandan <[email protected]> Subject: [PATCH] MdeModulePkg/UdfDxe: Remove negative comparison of unsigned number This patch gets rid of a negative comparison of an UINT64 type (Offset) as it'll never evaluate to true. Cc: Star Zeng <[email protected]> Cc: Eric Dong <[email protected]> Cc: Ruiyu Ni <[email protected]> Cc: Dandan Bi <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.1 Reported-by: Star Zeng <[email protected]> Signed-off-by: Paulo Alcantara <[email protected]> --- MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c b/MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c index 7286265373..2039f80289 100644 --- a/MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c +++ b/MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c @@ -1082,9 +1082,6 @@ ReadFile ( if (FilePosition + ExtentLength > ReadFileInfo->FilePosition) { Offset = ReadFileInfo->FilePosition - FilePosition; - if (Offset < 0) { - Offset = -(Offset); - } } else { Offset = 0; } -- 2.11.0 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
