It's a tab character in old version. It may look like the same if your tab width is to a certain number. In my editor, it looks unaligned. Sometimes I just can't resist the temptation to fix the tab:) I'll restore it to avoid irrelevant changes in next patch update.
-----Original Message----- From: Justen, Jordan L Sent: Thursday, September 14, 2017 2:34 PM To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org Cc: Yao, Jiewen <jiewen....@intel.com>; Dong, Eric <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com>; Laszlo Ersek <ler...@redhat.com>; Kinney, Michael D <michael.d.kin...@intel.com>; Wolman, Ayellet <ayellet.wol...@intel.com> Subject: RE: [PATCH 1/4] MdeModulePkg/Core: Implement NULL pointer detection in EDK-II Core. On 2017-09-13 18:25:22, Wang, Jian J wrote: > See my comments start with [Jian] below. > > -----Original Message----- > From: Justen, Jordan L > Sent: Thursday, September 14, 2017 1:28 AM > > > diff --git a/MdeModulePkg/Core/Dxe/DxeMain.inf > > b/MdeModulePkg/Core/Dxe/DxeMain.inf > > index 30d5984f7c..273b8b7c0e 100644 > > --- a/MdeModulePkg/Core/Dxe/DxeMain.inf > > +++ b/MdeModulePkg/Core/Dxe/DxeMain.inf > > @@ -179,7 +179,7 @@ > > gEfiWatchdogTimerArchProtocolGuid ## CONSUMES > > > > [FeaturePcd] > > - gEfiMdeModulePkgTokenSpaceGuid.PcdFrameworkCompatibilitySupport > > ## CONSUMES > > + gEfiMdeModulePkgTokenSpaceGuid.PcdFrameworkCompatibilitySupport > > ## CONSUMES > > Why is this line changed? > [Jian] Just align the comment followed because the new one added I was looking in the patch, and it didn't look like it was now aligned with the comments above or below. (It is 1 column less than the section below, right?) My opinion is to not change the line since it is in a separate section of the inf file. -Jordan > > > > > [Pcd] > > gEfiMdeModulePkgTokenSpaceGuid.PcdLoadFixAddressBootTimeCodePageNumber > > ## SOMETIMES_CONSUMES > > @@ -192,6 +192,7 @@ > > gEfiMdeModulePkgTokenSpaceGuid.PcdPropertiesTableEnable > > ## CONSUMES > > gEfiMdeModulePkgTokenSpaceGuid.PcdImageProtectionPolicy > > ## CONSUMES > > gEfiMdeModulePkgTokenSpaceGuid.PcdDxeNxMemoryProtectionPolicy > > ## CONSUMES > > + gEfiMdeModulePkgTokenSpaceGuid.PcdNullPointerDetectionPropertyMask > > ## CONSUMES _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
