Hi Hao,

On 15/09/2017 01:57, Hao Wu wrote:
The series introduces the following code refinements for UdfDxe &
PartitionDxe:

a. Add checks to ensure no possible NULL pointer dereference
b. Reslove operands of different size in bitwise operations
c. Use compare operator for non-boolean comparisons
d. Refine function description comments
e. Refine local variable initialization
f. Refine enum members naming style

Cc: Paulo Alcantara <[email protected]>
Cc: Ruiyu Ni <[email protected]>
Cc: Star Zeng <[email protected]>
Cc: Eric Dong <[email protected]>
Cc: Dandan Bi <[email protected]>

Hao Wu (7):
   MdeModulePkg/UdfDxe: Add checks to ensure no possible NULL ptr deref
   MdeModulePkg/UdfDxe: Fix operands of different size in bitwise OP
   MdeModulePkg/UdfDxe: Use compare operator for non-boolean comparisons
   MdeModulePkg/Udf: Refine function description comments
   MdeModulePkg/UdfDxe: Avoid short (single character) variable name
   MdeModulePkg/Udf: Avoid declaring and initializing local GUID variable
   MdeModulePkg/UdfDxe: Refine enum member naming style

  MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c            |  20 +-
  MdeModulePkg/Universal/Disk/UdfDxe/File.c                 |   5 +-
  MdeModulePkg/Universal/Disk/UdfDxe/FileName.c             |  27 +-
  MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 483 
+++++++++++++++-----
  MdeModulePkg/Universal/Disk/UdfDxe/Udf.h                  |  49 +-
  5 files changed, 432 insertions(+), 152 deletions(-)
Looks good to me. Also tested it with OVMF X64. Thanks!

Reviewed-by: Paulo Alcantara <[email protected]>

Paulo
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to