Really appreciate the Regression-tested-by, I will pick up it when pushing the patch.
Thanks, Star -----Original Message----- From: Laszlo Ersek [mailto:[email protected]] Sent: Monday, September 18, 2017 11:55 PM To: Zeng, Star <[email protected]>; Heyi Guo <[email protected]>; Pankaj Bansal <[email protected]>; [email protected] Cc: Ni, Ruiyu <[email protected]>; Ard Biesheuvel <[email protected]> Subject: Re: [edk2] [PATCH] Fix not able to change serial attributes On 09/18/17 12:22, Zeng, Star wrote: > Thanks for your good comments. :) > Since there is no clear description for the behavior of Reset() :(, I prone > to align the behavior with MdeModulePkg/Bus/Pci/PciSioSerialDxe/SerialIo.c > and IntelFrameworkModulePkg/Bus/Isa/IsaSerialDxe/Serial.c, that means I agree > the fix. > > > Laszlo and Gary, if you can help do some simple regression test with the > patch, that will be better. Never used the SERMODE command before, so I didn't try it now either. I tested the patch as follows: built ArmVirtQemu with it, and first checked normal use of the serial terminal, then issued a RECONNECT/CONNECT from the graphics console, and then verified if the serial terminal was working OK again (UEFI shell and Setup utility). I found no regression with this. Regression-tested-by: Laszlo Ersek <[email protected]> Thanks Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
