On 09/21/17 05:50, Ye, Ting wrote: > Hi Qin, > > I think we might add OPTIONAL attribute to CommonName, as NULL is an valid > input for this API. > In function description, I think we need update below statement to "if *** > and *CommonNameSize is 0." > > "If CommonName is not NULL and CommonNameSize is 0." > > Others are good to me. > > Reviewed-by: Ye Ting <[email protected]>
With those updates, the X509GetCommonName() interface looks good to me as well. I didn't check the implementation. Acked-by: Laszlo Ersek <[email protected]> Thanks! Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
