Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Friday, September 22, 2017 6:44 AM > To: Laszlo Ersek <ler...@redhat.com> > Cc: edk2-devel@lists.01.org; Carsey, Jaben <jaben.car...@intel.com>; Ni, > Ruiyu <ruiyu...@intel.com>; Shi, Steven <steven....@intel.com> > Subject: Re: [PATCH] ShellPkg/DmpStore: fix GCC/CLANG build failure > Importance: High > > > > On 22 Sep 2017, at 06:34, Laszlo Ersek <ler...@redhat.com> wrote: > > >> ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c:525:66: > error: > >> passing argument 2 of 'gEfiShellProtocol->GetGuidName' from > incompatible > >> pointer type [-Werror=incompatible-pointer-types] > >> > >> Status = gEfiShellProtocol->GetGuidName(&FoundVarGuid, > &GuidName); > >> ^ > >> ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c:525:66: > note: > >> expected 'const CHAR16 ** {aka const short unsigned int **}' but > >> argument is of type 'CHAR16 ** {aka short unsigned int **}' > > > > Pointer-to-(pointer-to-CHAR16) and pointer-to-(pointer-to-const-CHAR16) > > are incompatible types; GCC and CLANG are right to complain. > > > > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > > Cc: Jaben Carsey <jaben.car...@intel.com> > > Cc: Ruiyu Ni <ruiyu...@intel.com> > > Cc: Steven Shi <steven....@intel.com> > > Reported-by: Jenkins Build Host <jenk...@kraxel.org> > > Reported-by: Steven Shi <steven....@intel.com> > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=716 > > Fixes: 09e8678380aaaf0a5ef59179ff59e0a045d1b0bf > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > > --- > > > > Notes: > > I'm going to push this as soon as I get an R-b from anyone. > > > > Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > > > Thanks > > Laszlo > > > > ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > > index 062ab5dc3a9a..5791da9acc8c 100644 > > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > > @@ -424,7 +424,7 @@ CascadeProcessVariables ( > > CHAR16 *AttrString; > > CHAR16 *HexString; > > EFI_STATUS SetStatus; > > - CHAR16 *GuidName; > > + CONST CHAR16 *GuidName; > > > > if (ShellGetExecutionBreakFlag()) { > > return (SHELL_ABORTED); > > -- > > 2.14.1.3.gb7cf6e02401b > > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
