Liming, I agree this works, but I think Laszlo's change to make the GuidName a CONST CHAR makes more sense.
Jaben > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Liming Gao > Sent: Thursday, September 21, 2017 11:36 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com> > Subject: [edk2] [Patch] ShellPkg: Update the parameter type to match > function interface in DmpStore > Importance: High > > This fix can resolve CLANG38 build failure. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao <liming....@intel.com> > Cc: Ruiyu Ni <ruiyu...@intel.com> > --- > ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > index 062ab5d..c2b60fe 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > @@ -522,7 +522,7 @@ CascadeProcessVariables ( > Status = EFI_OUT_OF_RESOURCES; > } > } else { > - Status = gEfiShellProtocol->GetGuidName(&FoundVarGuid, > &GuidName); > + Status = gEfiShellProtocol->GetGuidName(&FoundVarGuid, (CONST > CHAR16 **) &GuidName); > if (EFI_ERROR (Status)) { > ShellPrintHiiEx ( > -1, -1, NULL, STRING_TOKEN (STR_DMPSTORE_HEADER_LINE), > gShellDebug1HiiHandle, > -- > 2.8.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
