Based on the feedbacks from Liming, the V3 series drops the patch for
MdeModulePkg/Crc32. Since the left shift operation "1 << Index" will be
removed by an under-reviewing patch series:
[Patch 0/2] Add CalculateCrc32() API in MdePkg BaseLib
V2 history:
According to the feebacks from Paolo, the following changes are made in
this version of patch series:
a. Refine the code logic in Tpl.c to void left shifting the negative
value. Also makes the code more readable;
b. Remove the '~' operator before 'Time.Hour' in DxeNetLib.c, since it
seems like an implementation choice for generating the seed;
c. Use '1U' instead of '(UINT32)1' in Crc32.c.
V1 history:
The series resolves two kinds of undefined behaviours in left shift
operations:
a. Left-shifting negative values;
b. Left-shifting that incurs the result being out of range.
Cc: Steven Shi <[email protected]>
Cc: Michael Kinney <[email protected]>
Cc: Liming Gao <[email protected]>
Cc: Star Zeng <[email protected]>
Cc: Eric Dong <[email protected]>
Cc: Fu Siyuan <[email protected]>
Cc: Ye Ting <[email protected]>
Cc: Wu Jiaxin <[email protected]>
Cc: Qin Long <[email protected]>
Cc: Paolo Bonzini <[email protected]>
Hao Wu (5):
MdePkg/PrintLib: Fix possible negative value left shift
MdeModulePkg/PrintLib: Fix possible negative value left shift
MdeModulePkg/Tpl: Fix negative value left shift
MdeModulePkg/DxeNetLib: Fix negative value left shift
MdeModulePkg/AtaAtapiPassThru: Fix possible out of range left shift
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 4 ++--
MdeModulePkg/Core/Dxe/Event/Tpl.c | 12 +++++++++---
MdeModulePkg/Library/DxeNetLib/DxeNetLib.c | 2 +-
MdeModulePkg/Library/DxePrintLibPrint2Protocol/PrintLib.c | 2 +-
MdePkg/Library/BasePrintLib/PrintLibInternal.c | 2 +-
5 files changed, 14 insertions(+), 8 deletions(-)
--
2.12.0.windows.1
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
