Reviewed-by: Jaben Carsey <[email protected]> > -----Original Message----- > From: Ni, Ruiyu > Sent: Wednesday, September 27, 2017 10:57 PM > To: Bi, Dandan <[email protected]>; [email protected] > Cc: Carsey, Jaben <[email protected]> > Subject: RE: [patch] ShellPkg/Dh: Refine variable naming style > Importance: High > > Reviewed-by: Ruiyu Ni <[email protected]> > > Thanks/Ray > > > -----Original Message----- > > From: Bi, Dandan > > Sent: Thursday, September 28, 2017 10:45 AM > > To: [email protected] > > Cc: Ni, Ruiyu <[email protected]>; Carsey, Jaben > <[email protected]> > > Subject: [patch] ShellPkg/Dh: Refine variable naming style > > > > Avoid using only lower-case characters for variable name. > > > > Cc: Ruiyu Ni <[email protected]> > > Cc: Jaben Carsey <[email protected]> > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Dandan Bi <[email protected]> > > --- > > ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c > > b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c > > index 7d06163..a7bd251 100644 > > --- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c > > +++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c > > @@ -284,11 +284,11 @@ GetProtocolInfoString( > > EFI_STATUS Status; > > CHAR16 *RetVal; > > UINTN Size; > > CHAR16 *Temp; > > CHAR16 GuidStr[40]; > > - VOID *instance; > > + VOID *Instance; > > CHAR16 InstanceStr[17]; > > > > ProtocolGuidArray = NULL; > > RetVal = NULL; > > Size = 0; > > @@ -314,14 +314,14 @@ GetProtocolInfoString( > > FreePool(Temp); > > } > > StrnCatGrow(&RetVal, &Size, L"%N", 0); > > > > if(Verbose) { > > - Status = gBS->HandleProtocol (TheHandle, > > ProtocolGuidArray[ProtocolIndex], &instance); > > + Status = gBS->HandleProtocol (TheHandle, > > ProtocolGuidArray[ProtocolIndex], &Instance); > > if (!EFI_ERROR (Status)) { > > StrnCatGrow (&RetVal, &Size, L"(%H", 0); > > - UnicodeSPrint (InstanceStr, sizeof (InstanceStr), L"%x", > > instance); > > + UnicodeSPrint (InstanceStr, sizeof (InstanceStr), L"%x", > > Instance); > > StrnCatGrow (&RetVal, &Size, InstanceStr, 0); > > StrnCatGrow (&RetVal, &Size, L"%N)", 0); > > } > > } > > > > -- > > 1.9.5.msysgit.1
_______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
