On Mon, Oct 09, 2017 at 06:25:18PM +0200, Marcin Wojtas wrote: > 2017-10-09 18:23 GMT+02:00 Leif Lindholm <[email protected]>: > > On Mon, Oct 09, 2017 at 06:06:53PM +0200, Marcin Wojtas wrote: > >> 2017-10-09 18:00 GMT+02:00 Leif Lindholm <[email protected]>: > >> > On Sun, Oct 08, 2017 at 12:56:50PM +0200, Marcin Wojtas wrote: > >> >> This patch introduces UTMI description, using the new structures > >> >> and template in MvHwDescLib. This change enables more flexible > >> >> addition of multiple CP with UTMI PHY's and also significantly > >> >> reduces amount of used PCD's for that purpose. Update PortingGuide > >> >> documentation accordingly. > >> >> > >> >> This patch replaces string-based description of Utmi on > >> >> Armada 70x0 DB with new, reduced format, which uses macros > >> >> in Armada.dsc.inc file for better readability. > >> >> > >> >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> >> Signed-off-by: Marcin Wojtas <[email protected]> > >> >> --- > >> >> Platform/Marvell/Armada/Armada.dsc.inc | 5 + > >> >> Platform/Marvell/Armada/Armada70x0.dsc | 7 +- > >> >> Platform/Marvell/Include/Library/MvHwDescLib.h | 47 ++++++ > >> >> Platform/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c | 150 > >> >> ++++++++++---------- > >> >> Platform/Marvell/Library/UtmiPhyLib/UtmiPhyLib.h | 1 - > >> >> Platform/Marvell/Library/UtmiPhyLib/UtmiPhyLib.inf | 11 +- > >> >> Platform/Marvell/Marvell.dec | 7 +- > >> >> Silicon/Marvell/Documentation/PortingGuide.txt | 30 ++-- > >> >> 8 files changed, 148 insertions(+), 110 deletions(-) > >> >> > > > >> > This indentation does not appear to follow any of the patterns > >> > permitted by the coding style. Please address here and in the two > >> > instances below (calls to UtmiPhyConfig and UtmiPhyPowerUp). > >> > > >> > No need to resubmit the whole series - just the single patch. > >> > >> Sure, will send right away. > > > > Thx. > > Rebased patches are available here: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/parsepcd-upstream-r20171009
Thanks - for the series: Reviewed-by: Leif Lindholm <[email protected]> Pushed as 7f0f07968b..a1b8b22b97 / Leif _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
