On Tue, Oct 10, 2017 at 04:50:04PM +0200, Marcin Wojtas wrote: > 2017-10-10 16:43 GMT+02:00 Leif Lindholm <[email protected]>: > > On Mon, Oct 09, 2017 at 07:00:53PM +0200, Marcin Wojtas wrote: > >> From: Ard Biesheuvel <[email protected]> > >> > >> To prevent cache coherency issues when chainloading via U-Boot, clean > >> and invalidate the FV image in the caches before re-enabling the MMU. > > > > Is this only relevant for chainloading (which is not the expected > > normal usage) or is it also important for warm-reset - for example for > > capsule update (at least from within OS)? > > Initially it was done for chainloading purpose - I don't use it > anymore, but just thought the patch itself is worth keeping. About > capsule update - I haven't tried it, it's been not the top priority > for me recently. > > > If the former, I would prefer for this to be conditionalised, and not > > included by default. > > How can we detect, that uefi is being chain-loaded?
Oh, I meant compile time. Hence "not included by default". It has been a useful debug feature, but I don't think anyone is expecting to be routinely run either EDK2 on top of U-Boot or U-Boot on top of EDK2 on this platform. > > If the latter, please update the commit message. > > I'm considering keeping this patch aside, until it may become > necessary for capsule update, as I cannot guarantee now it's needed at > all. What's your recommendation? I'll wait to see what Ard has to say. So yes, it may make sense to move it out of the series for now. Regards, Leif _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
