On 10/10/17 10:39, Ruiyu Ni wrote: > BmCharToUint() could be called using external data and it > already contains logic to return -1 when data is invalid, > so removing unnecessary assertion to avoid system hang. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni <[email protected]> > Cc: Ard Biesheuvel <[email protected]> > Cc: Laszlo Ersek <[email protected]> > --- > MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c > b/MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c > index 11ab86792a..a3fa254245 100644 > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c > +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c > @@ -420,7 +420,6 @@ BmCharToUint ( > return (Char - L'A' + 0xA); > } > > - ASSERT (FALSE); > return (UINTN) -1; > } > >
Reviewed-by: Laszlo Ersek <[email protected]> Thanks! Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
