On Tue, Sep 26, 2017 at 09:15:16PM +0100, [email protected] wrote: > From: Girish Pathak <[email protected]> > > Minor code change, replaces magic number with macro in LCD disable. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Girish Pathak <[email protected]> > Signed-off-by: Evan Lloyd <[email protected]>
Always appreciated. Reviewed-by: Leif Lindholm <[email protected]> > --- > ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111Lcd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111Lcd.c > b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111Lcd.c > index > f432c8d802614e8a0e4ddab3898f6e0dbf9a1572..12db9d910ed1d7874095a5f79fe588491811f75a > 100644 > --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111Lcd.c > +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111Lcd.c > @@ -122,8 +122,7 @@ LcdSetMode ( > } > > // Disable the CLCD_LcdEn bit > - LcdControl = MmioRead32 (PL111_REG_LCD_CONTROL); > - MmioWrite32 (PL111_REG_LCD_CONTROL, LcdControl & ~1); > + MmioAnd32 (PL111_REG_LCD_CONTROL, ~PL111_CTRL_LCD_EN); > > // Set Timings > MmioWrite32 ( > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
