The Idea of PCDs would be great. I always change the UefiShellLib EFI_BLUE to EFI_CYAN to get a brighter blue.
thanks, Laurie [email protected] Intel SSG/STO/EBP (503) 712-9395 -----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of Carsey, Jaben Sent: Monday, October 16, 2017 9:32 AM To: Ni, Ruiyu <[email protected]>; [email protected] Subject: Re: [edk2] [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color Reviewed-by: Jaben Carsey <[email protected]> We could also use some PCDs if different people really want different colors in the future... > -----Original Message----- > From: Ni, Ruiyu > Sent: Monday, October 16, 2017 12:31 AM > To: [email protected] > Cc: Carsey, Jaben <[email protected]> > Subject: [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green > color > Importance: High > > Some developers/QAs complain the color of directory or executable > files is hard to see and suggest to use a more bright color. > I agree with this suggestion so make this patch. > The look and feel is much better now. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni <[email protected]> > Cc: Jaben Carsey <[email protected]> > --- > ShellPkg/Library/UefiShellLib/UefiShellLib.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > index 64565f81d8..25d3e33533 100644 > --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > @@ -2849,10 +2849,10 @@ InternalShellPrintWorker( > gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_WHITE, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > break; > case (L'B'): > - gST->ConOut->SetAttribute(gST->ConOut, EFI_TEXT_ATTR(EFI_BLUE, > ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > + gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_LIGHTBLUE, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > break; > case (L'V'): > - gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_GREEN, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > + gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_LIGHTGREEN, > ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > break; > default: > // > -- > 2.12.2.windows.2 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
