On Mon, Oct 16, 2017 at 10:08:29PM +0800, Zhang, Chao B wrote:
> Fix GCC build error
>
> Cc: Long Qin <[email protected]>
> Cc: Gary Lin <[email protected]>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Chao Zhang <[email protected]>
> ---
> SecurityPkg/Library/AuthVariableLib/AuthService.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/SecurityPkg/Library/AuthVariableLib/AuthService.c
> b/SecurityPkg/Library/AuthVariableLib/AuthService.c
> index 7188ff6..1e7872a 100644
> --- a/SecurityPkg/Library/AuthVariableLib/AuthService.c
> +++ b/SecurityPkg/Library/AuthVariableLib/AuthService.c
> @@ -1564,7 +1564,7 @@ CalculatePrivAuthVarSignChainSHA256Digest(
> //
> // Get SignerCert CommonName
> //
> - Status = X509GetCommonName(SignerCert, SignerCertSize, CertCommonName,
> &CertCommonNameSize);
> + Status = X509GetCommonName(SignerCert, SignerCertSize, (CHAR8
> *)CertCommonName, &CertCommonNameSize);
Hi Chao Zhang,
Although casting also silences the warning, why not declare
CertCommonName as CHAR8 directly? The only signedness check happens
in X509GetCommonName(). Sha256Update() requests "VOID *" so the
signedness doesn't matter. Besides, AsciiStrLen() also requests
CHAR8, so declaring CertCommonName as CHAR8 can remove the casting
altogether. What do you think?
Gary Lin
> if (EFI_ERROR(Status)) {
> DEBUG((DEBUG_INFO, "%a Get SignerCert CommonName failed with status
> %x\n", __FUNCTION__, Status));
> return EFI_ABORTED;
> --
> 1.9.5.msysgit.1
>
> _______________________________________________
> edk2-devel mailing list
> [email protected]
> https://lists.01.org/mailman/listinfo/edk2-devel
>
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
