Please ignore the mail titled with: [edk2] Recall: [PATCH] Shellpkg/editor: Fix a bug that may modifies Line[-1]
Since I received a notification that my previous r-b mail was rejected by the edk2-devel mailing list. Sorry for the noise. Best Regards, Hao Wu > -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of Wu, > Hao A > Sent: Thursday, October 26, 2017 9:38 AM > To: Ni, Ruiyu; [email protected] > Cc: Carsey, Jaben > Subject: Re: [edk2] [PATCH] Shellpkg/editor: Fix a bug that may modifies > Line[-1] > > Reviewed-by: Hao Wu <[email protected]> > > Best Regards, > Hao Wu > > > -----Original Message----- > > From: Ni, Ruiyu > > Sent: Wednesday, October 25, 2017 9:03 AM > > To: [email protected] > > Cc: Carsey, Jaben; Wu, Hao A > > Subject: [PATCH] Shellpkg/editor: Fix a bug that may modifies Line[-1] > > > > The original code as below intend to set the character > > before last column to CHAR_NULL. > > Line[(LastCol % (ARRAY_SIZE (Line) - 1)) - 1] = CHAR_NULL; > > > > But when LastCol % (ARRAY_SIZE (Line) - 1)) equals to 0, > > Line[-1] is modified. > > > > We should change to code as below: > > Line[(LastCol - 1) % (ARRAY_SIZE (Line) - 1)] = CHAR_NULL; > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ruiyu Ni <[email protected]> > > Cc: Jaben Carsey <[email protected]> > > Cc: Hao A Wu <[email protected]> > > --- > > .../Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.c > | > > 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Commands > > Lib.c > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Commands > > Lib.c > > index d26d08f95c..b45e9a33f3 100644 > > --- > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Commands > > Lib.c > > +++ > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Commands > > Lib.c > > @@ -205,7 +205,7 @@ EditorClearLine ( > > // > > // if CHAR_NULL is still at position LastCol, it will cause first > > line error > > // > > - Line[(LastCol % (ARRAY_SIZE (Line) - 1)) - 1] = CHAR_NULL; > > + Line[(LastCol - 1) % (ARRAY_SIZE (Line) - 1)] = CHAR_NULL; > > } else { > > Line[LastCol % (ARRAY_SIZE (Line) - 1)] = CHAR_NULL; > > } > > -- > > 2.12.2.windows.2 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
