On Thu, Oct 26, 2017 at 03:19:29AM +0200, Marcin Wojtas wrote:
> In MvI2cStartRequest the status was assigned to the variable
> without dereferencing a pointer. Fix it.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <[email protected]>
> ---
> Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c
> b/Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c
> index 7faf1f7..8ed96f0 100755
> --- a/Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c
> +++ b/Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c
> @@ -631,7 +631,7 @@ MvI2cStartRequest (
> }
>
> if (I2cStatus != NULL)
> - I2cStatus = EFI_SUCCESS;
> + *I2cStatus = Status;
Oh, that's horrible! And only did not generate warnings because
EFI_SUCCESS is 0.
However, you also change from setting *I2cStatus to Status instead of
EFI_SUCCESS. This should be mentioned in commit message.
/
Leif
> if (Event != NULL)
> gBS->SignalEvent(Event);
> return EFI_SUCCESS;
> --
> 2.7.4
>
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
