On Thu, Oct 26, 2017 at 03:57:38PM +0100, Ard Biesheuvel wrote:
> On 26 October 2017 at 15:56, Leif Lindholm <[email protected]> wrote:
> > On Wed, Oct 25, 2017 at 06:59:27PM +0100, Ard Biesheuvel wrote:
> >> Replace the common MemoryInitPeiLib implementation with one that does
> >> not remove the primary FV from the memory map. This is a waste of
> >> memory and TLB entries, given that the OS can no longer use a 1 GB
> >> block mapping to map this memory.
> >>
> >> Since we have our own implementation now, there is no point in using
> >> ArmPlatformLib's GetVirtualMemoryMap() implementation, and we can
> >> simply declare and map the regions directly.
> >>
> >> Contributed-under: TianoCore Contribution Agreement 1.1
> >> Signed-off-by: Ard Biesheuvel <[email protected]>
> >
> > This one still has commented-out bits of code.
> > I don't really want to have that in master.
> > Are we holding off on pushing until we get the dynamic detection
> > support ove SCMI, and are we expecting to drop the commented-out bits
> > when we do?
>
> Yes.
Right, so this is my only comment on this patch, but I guess there
will be non-trivial changes once that happens, so there's probably no
point for me to give a r-b at this point.
/
Leif
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
