Hi, I present you a second version of the patchset with post review fixes and improvements. 9/10 patch was completely changed - the diff is bigger, but such generic clock handling gives some chances to benefit if we want to merge Xenon support with original EDK2 SdMmc driver in future. More details can be found in the commit logs and a changelog below.
The patches are available in the github: https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/misc-upstream-r20171027 I'm looking forward to your comments or remarks. Best regards, Marcin Changelog: v1 -> v2: 1/10 - remove unrelated style fix - fix style around modified functions calls 2/10 - leave original EFI_SUCCESS assignment 6/10 - use descriptively named temporary variable for pin index in a loop 7/10 - use single flag for link up/down - simplify logic - correct style 8/10 - mention missing SDR25 in a commit message 9/10 - use new member of SD_MMC_HC_PRIVATE_DATA to set actual input clock speed and use it for the output clock configuration - rewrite commit message 3/10, 4/10, 5/10, 10/10 - add RB's Ard Biesheuvel (2): Marvell/Library: MppLib: Disable the stack protector Marvell/Library: MppLib: Take 0xFF placeholders into account David Greeson (2): Marvell/Drivers: MvI2cDxe: Abort transaction immediately upon fail Marvell/Drivers: MvI2cDxe: Reduce bus occupation time Joe Zhou (1): Marvell/Library: MppLib: Prevent overwriting PCD values Marcin Wojtas (5): Marvell/Drivers: MvI2cDxe: Fix returning status in MvI2cStartRequest Marvell/Drivers: Pp2Dxe: Change settings for the always-up link Marvell/Drivers: XenonDxe: Fix UHS signalling mode setting Marvell/Drivers: XenonDxe: Allow overriding base clock frequency Marvell/Drivers: XenonDxe: Do not modify FIFO default values Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c | 70 ++++++++++++-------- Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.h | 2 +- Platform/Marvell/Drivers/Net/Pp2Dxe/Mvpp2Lib.c | 25 +++++++ Platform/Marvell/Drivers/Net/Pp2Dxe/Mvpp2Lib.h | 6 ++ Platform/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c | 6 +- Platform/Marvell/Drivers/SdMmc/XenonDxe/EmmcDevice.c | 6 +- Platform/Marvell/Drivers/SdMmc/XenonDxe/SdDevice.c | 4 +- Platform/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDxe.c | 13 ++-- Platform/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDxe.h | 6 ++ Platform/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHci.c | 22 +++--- Platform/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHci.h | 12 ++-- Platform/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.c | 16 ----- Platform/Marvell/Library/MppLib/MppLib.c | 35 +++++----- Platform/Marvell/Library/MppLib/MppLib.inf | 3 + 14 files changed, 140 insertions(+), 86 deletions(-) -- 2.7.4 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
