On 26 October 2017 at 22:33, Leif Lindholm <[email protected]> wrote: > On Wed, Oct 25, 2017 at 06:59:43PM +0100, Ard Biesheuvel wrote: >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel <[email protected]> >> --- >> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc >> | 20 +++++ >> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf >> | 92 +++++++++++++++++++- >> >> Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc >> | 80 +++++++++++++++++ >> >> Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf >> | 46 ++++++++++ >> >> Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareDescriptor/SystemFirmwareDescriptorPei.c >> | 68 +++++++++++++++ >> >> Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareUpdateConfig/SystemFirmwareUpdateConfig.ini >> | 25 ++++++ >> 6 files changed, 328 insertions(+), 3 deletions(-) >> >> diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc >> b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc >> index cb6922a5940e..78c92cbca5a2 100644 >> --- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc >> +++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc >> @@ -120,6 +120,10 @@ [LibraryClasses.common] >> NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf >> NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf >> >> + BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf >> + OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf >> + IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf >> + >> [LibraryClasses.common.SEC] >> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >> BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf >> @@ -154,7 +158,15 @@ [LibraryClasses.common.DXE_CORE] >> [LibraryClasses.common.DXE_DRIVER] >> >> SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf >> >> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf >> + >> + # >> + # Firmware update >> + # >> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf >> + >> EdkiiSystemCapsuleLib|SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf >> + >> FmpAuthenticationLib|SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.inf >> + >> PlatformFlashAccessLib|Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.inf >> + IniParsingLib|SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.inf >> >> # >> # PCI >> @@ -580,3 +592,11 @@ [Components.common] >> <LibraryClasses> >> >> DtPlatformDtbLoaderLib|EmbeddedPkg/Library/DxeDtPlatformDtbLoaderLibDefault/DxeDtPlatformDtbLoaderLibDefault.inf >> } >> + >> + # >> + # Firmware update >> + # >> + >> Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf >> + MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf >> + >> SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf >> + >> SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.inf >> diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf >> b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf >> index 1e3258821a8c..337486d361fc 100644 >> --- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf >> +++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf >> @@ -27,12 +27,12 @@ >> >> [FD.BL33_AP_UEFI] >> BaseAddress = 0x08200000|gArmTokenSpaceGuid.PcdFdBaseAddress # The base >> address of the Firmware in NOR Flash. >> -Size = 0x001B0000|gArmTokenSpaceGuid.PcdFdSize # The size >> in bytes of the FLASH Device >> +Size = 0x001A0000|gArmTokenSpaceGuid.PcdFdSize # The size >> in bytes of the FLASH Device >> ErasePolarity = 1 >> >> # This one is tricky, it must be: BlockSize * NumBlocks = Size >> BlockSize = 0x00010000 >> -NumBlocks = 0x1B >> +NumBlocks = 0x1A >> >> >> ################################################################################ >> # >> @@ -50,7 +50,7 @@ [FD.BL33_AP_UEFI] >> # >> >> ################################################################################ >> >> -0x00000000|0x001B0000 >> +0x00000000|0x001A0000 > > There are a few "could you sort please" things I could comment about > below, but this is the only thing that really looks out of place to > me. Why is this being shrunk as part of this patch? If intentional and > related, this really needs a comment in the commit message. >
No, not really. I will remove it. _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
