On Tue, Oct 31, 2017 at 04:59:32AM +0100, Marcin Wojtas wrote:
> Flash commands macros are already defined locally, so
> remove them from the protocol header.
Locally?
I have no issue with the patch, but the commit message can be a bit
more descriptive.
/
Leif
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <[email protected]>
> ---
> Platform/Marvell/Include/Protocol/SpiFlash.h | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/Platform/Marvell/Include/Protocol/SpiFlash.h
> b/Platform/Marvell/Include/Protocol/SpiFlash.h
> index 4a3053e..4ba29ba 100644
> --- a/Platform/Marvell/Include/Protocol/SpiFlash.h
> +++ b/Platform/Marvell/Include/Protocol/SpiFlash.h
> @@ -36,17 +36,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
> DAMAGE.
>
> #include <Protocol/Spi.h>
>
> -#define CMD_READ_ID 0x9f
> -#define READ_STATUS_REG_CMD 0x0b
> -#define CMD_WRITE_ENABLE 0x06
> -#define CMD_FLAG_STATUS 0x70
> -#define CMD_WRITE_STATUS_REG 0x01
> -#define CMD_READ_ARRAY_FAST 0x0b
> -#define CMD_PAGE_PROGRAM 0x02
> -#define CMD_BANK_WRITE 0xc5
> -#define CMD_ERASE_64K 0xd8
> -#define CMD_4B_ADDR_ENABLE 0xb7
> -
> extern EFI_GUID gMarvellSpiFlashProtocolGuid;
>
> typedef struct _MARVELL_SPI_FLASH_PROTOCOL MARVELL_SPI_FLASH_PROTOCOL;
> --
> 2.7.4
>
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
