Hi Zeng,

On 30 October 2017 at 01:09, Zeng, Star <[email protected]> wrote:
> I do not think SerialDxe should handle EFI_INVALID_PARAMETER return value 
> from SerialPortSetAttributes().
> If the EFI_INVALID_PARAMETER is because of Timeout value, the Timeout value 
> definitely should not be updated.
> If the EFI_INVALID_PARAMETER is because of other parameters, the status 
> should be returned to the caller.

Fair enough. Are you going to resend the change you suggest with a
commit message?

Cheers,

-- 
Julien Grall
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to