It works Fine. Are you going to check in this changes, could you please let us know the plan?
-----Original Message----- From: Gao, Liming [mailto:[email protected]] Sent: Monday, November 06, 2017 6:59 PM To: Karunakar P; 'Tim Lewis'; '[email protected]' Cc: Ye, Ting; Fu, Siyuan; Wu, Jiaxin Subject: RE: [edk2] Build error in StdLib with VS 2015 compiler For VS2015, don't define it. The change is like below. #ifndef __STDC_HOSTED__ #if !defined(_MSC_VER) || _MSC_VER != 1900 #define __STDC_HOSTED__ 1 #endif #endif > -----Original Message----- > From: Karunakar P [mailto:[email protected]] > Sent: Monday, November 6, 2017 5:32 PM > To: Gao, Liming <[email protected]>; 'Tim Lewis' > <[email protected]>; '[email protected]' > <[email protected]> > Cc: Ye, Ting <[email protected]>; Fu, Siyuan <[email protected]>; > Wu, Jiaxin <[email protected]> > Subject: RE: [edk2] Build error in StdLib with VS 2015 compiler > > What do you say... > > > Thanks, > Karunakar > > -----Original Message----- > From: Karunakar P > Sent: Thursday, November 02, 2017 8:17 PM > To: 'Gao, Liming'; 'Tim Lewis'; [email protected] > Cc: Ye, Ting; Fu, Siyuan; Wu, Jiaxin > Subject: RE: [edk2] Build error in StdLib with VS 2015 compiler > > Then it works fine. > But the problem is it may miss the backward compatibility with other > compilers. > > I guess better to define as mentioned previously. > > Thank You, > Karunakar > > -----Original Message----- > From: Gao, Liming [mailto:[email protected]] > Sent: Thursday, November 02, 2017 7:33 PM > To: Karunakar P; 'Tim Lewis'; [email protected] > Cc: Ye, Ting; Fu, Siyuan; Wu, Jiaxin > Subject: RE: [edk2] Build error in StdLib with VS 2015 compiler > > Could you remove them, and build again? > > > -----Original Message----- > > From: edk2-devel [mailto:[email protected]] On Behalf > > Of Karunakar P > > Sent: Thursday, November 2, 2017 8:32 PM > > To: 'Tim Lewis' <[email protected]>; [email protected] > > Cc: Ye, Ting <[email protected]>; Fu, Siyuan <[email protected]>; > > Wu, Jiaxin <[email protected]> > > Subject: Re: [edk2] Build error in StdLib with VS 2015 compiler > > > > It is C only. > > > > -Karunakar > > > > -----Original Message----- > > From: Tim Lewis [mailto:[email protected]] > > Sent: Thursday, November 02, 2017 8:59 AM > > To: Karunakar P; [email protected] > > Cc: 'Ye, Ting'; 'Fu, Siyuan'; 'Wu, Jiaxin' > > Subject: RE: [edk2] Build error in StdLib with VS 2015 compiler > > > > Are you building C++ (.cpp)? Tim > > > > -----Original Message----- > > From: edk2-devel [mailto:[email protected]] On Behalf > > Of Karunakar P > > Sent: Wednesday, November 1, 2017 8:27 PM > > To: '[email protected]' <[email protected]> > > Cc: 'Ye, Ting' <[email protected]>; 'Fu, Siyuan' > > <[email protected]>; 'Wu, Jiaxin' <[email protected]> > > Subject: Re: [edk2] Build error in StdLib with VS 2015 compiler > > > > Any comment on this? > > > > From: Karunakar P > > Sent: Tuesday, October 31, 2017 3:18 PM > > To: '[email protected]' > > Cc: 'Wu, Jiaxin'; 'Fu, Siyuan'; 'Ye, Ting' > > Subject: Build error in StdLib with VS 2015 compiler > > > > Hello All, > > > > Facing an build error with Stdlib module when built with VS 2015 compiler. > > > > e:\test\StdLib\Include\sys/EfiCdefs.h(357): error C2220: warning > > treated as error - no 'object' file generated > > e:\test\StdLib\Include\sys/EfiCdefs.h(357): warning C4117: macro > > name '__STDC_HOSTED__' is reserved, '#define' ignored > > > > below change resolving this error. Would you please review and provide > > comments. > > > > #ifndef __STDC_HOSTED__ > > #define __STDC_HOSTED__ 1 > > #endif > > > > > > Thank You, > > Karunakar > > _______________________________________________ > > edk2-devel mailing list > > [email protected] > > https://lists.01.org/mailman/listinfo/edk2-devel > > > > _______________________________________________ > > edk2-devel mailing list > > [email protected] > > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
