Just a friendly reminder.
The recent commits have fixed two blocking issues for checking in heap guard
feature.
6fe575d052e36b243657a5885b5457decac41f03 (BaseCryptLib memory overflow)
cf8197a39d07179027455421a182598bd6989999
5df73e2cc8e39da97d56da058667607f1c43acac (AllocateCopyPool memory
overflow)
2a6ede28fd8efd3051794e1f2727a692d2725fe9
469293f8ee406f2b0bad2cf3bbbc510b2a1364eb
Please give your r-b if no more comments. I'd be happy to check in this patch
soon.
Thanks,
Jian
> -----Original Message-----
> From: edk2-devel [mailto:[email protected]] On Behalf Of Jian J
> Wang
> Sent: Friday, October 27, 2017 2:12 PM
> To: [email protected]
> Subject: [edk2] [PATCH v4 0/7] Implement heap guard feature
>
> > Path V4 changes:
> > a. Change names of gEdkiiSmmMemoryAttributeProtocolGuid related
> > definitions from EFI_ to EDKII_
> > b. Coding style cleanup
> > c. Split patches in a more reasonable order and groups
>
> > Patch V3 changes:
> > a. Add new protocol gEdkiiSmmMemoryAttributeProtocolGuid to do
> > memory attributes update instead of doing it directly in SmmCore
> > b. Fix GCC build error
>
> > Patch V2 changes:
> > a. Remove local variable initializer with memory copy from globals
> > b. Change map table dump code to use DEBUG_PAGE|DEBUG_POOL level
> > message
> > c. Fix malfunction in 32-bit boot mode
> > d. Add comment for the use of mOnGuarding
> > e. Change name of function InitializePageTableLib to
> > InitializePageTableGlobals
> > f. Add code in 32-bit code to bypass setting page table to read-only
> > g. Coding style clean-up
> >
>
> This feature makes use of paging mechanism to add a hidden (not present)
> page just before and after the allocated memory block. If the code tries
> to access memory outside of the allocated part, page fault exception will
> be triggered.
>
> This feature is disabled by default and is not recommended to enable it
> in production build of BIOS.
>
> This patch has passed following validations:
>
> a. Boot to shell (OVMF, Intel real platform)(32/64)
> b. Boot to Fedora 25 (64)
>
> NT32 emulation platform was not validated with this feature enabled
> due to the fact that it doesn't support paging which is needed for
> this feature to work. But all are validated with feature is disabled.
>
> Suggested-by: Ayellet Wolman <[email protected]>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang <[email protected]>
>
> Jian J Wang (7):
> MdeModulePkg/MdeModulePkg.dec,.uni: Add Protocol, PCDs and string
> tokens
> MdeModulePkg/SmmMemoryAttribute.h: Add new protocol definitions
> UefiCpuPkg/CpuDxe: Reduce debug message
> MdeModulePkg/DxeIpl: Enable paging for heap guard
> MdeModulePkg/DxeCore: Implement heap guard feature for UEFI
> UefiCpuPkg/PiSmmCpuDxeSmm: Add SmmMemoryAttribute protocol
> MdeModulePkg/PiSmmCore: Implement heap guard feature for SMM mode
>
> MdeModulePkg/Core/Dxe/DxeMain.inf | 4 +
> MdeModulePkg/Core/Dxe/Mem/HeapGuard.c | 1182
> ++++++++++++++++
> MdeModulePkg/Core/Dxe/Mem/HeapGuard.h | 394 ++++++
> MdeModulePkg/Core/Dxe/Mem/Imem.h | 38 +-
> MdeModulePkg/Core/Dxe/Mem/Page.c | 130 +-
> MdeModulePkg/Core/Dxe/Mem/Pool.c | 154 +-
> MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf | 1 +
> MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c | 36 +-
> MdeModulePkg/Core/PiSmmCore/HeapGuard.c | 1467
> ++++++++++++++++++++
> MdeModulePkg/Core/PiSmmCore/HeapGuard.h | 398 ++++++
> MdeModulePkg/Core/PiSmmCore/Page.c | 52 +-
> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 7 +-
> MdeModulePkg/Core/PiSmmCore/PiSmmCore.h | 81 +-
> MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf | 8 +
> MdeModulePkg/Core/PiSmmCore/Pool.c | 81 +-
> MdeModulePkg/Include/Protocol/SmmMemoryAttribute.h | 136 ++
> MdeModulePkg/MdeModulePkg.dec | 60 +
> MdeModulePkg/MdeModulePkg.uni | 58 +
> UefiCpuPkg/CpuDxe/CpuPageTable.c | 5 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c | 10 +
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 20 +
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 98 ++
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 2 +
> UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 163 +++
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 10 +-
> 25 files changed, 4496 insertions(+), 99 deletions(-)
> create mode 100644 MdeModulePkg/Core/Dxe/Mem/HeapGuard.c
> create mode 100644 MdeModulePkg/Core/Dxe/Mem/HeapGuard.h
> create mode 100644 MdeModulePkg/Core/PiSmmCore/HeapGuard.c
> create mode 100644 MdeModulePkg/Core/PiSmmCore/HeapGuard.h
> create mode 100644 MdeModulePkg/Include/Protocol/SmmMemoryAttribute.h
>
> --
> 2.14.1.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> [email protected]
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
