On 15 November 2017 at 13:34, Udit Kumar <[email protected]> wrote: > Hi, > I recently noticed in my build as well, we need to include CapsuleLib even > platform does not support Capsule update feature. > Thanks to help me, why this dependency is added in edk2. >
It was added as a dependency to ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf, for capsule update support. >> -----Original Message----- >> From: edk2-devel [mailto:[email protected]] On Behalf Of Ard >> Biesheuvel >> Sent: Tuesday, November 14, 2017 4:48 PM >> To: Kalyan Nagabhirava <[email protected]> >> Cc: [email protected]; Leif Lindholm <[email protected]>; Mark >> Gregotski <[email protected]> >> Subject: Re: [edk2] [PATCH edk2-platforms]: resolving Hikey platform build >> error >> >> On 14 November 2017 at 11:16, Kalyan Nagabhirava >> <[email protected]> wrote: >> > >> > "Instance of library class [CapsuleLib] is not found" build error is >> > coming for Hikey platform, to resolve this issueadded CapsuleLib to >> > "LibraryClasses.common" section >> > >> > diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc >> > b/Platform/Hisilicon/HiKey/HiKey.dsc >> > index 968e8ac..2e3b1c8 100644 >> > --- a/Platform/Hisilicon/HiKey/HiKey.dsc >> > +++ b/Platform/Hisilicon/HiKey/HiKey.dsc >> > @@ -61,6 +61,7 @@ >> > >> > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchroni >> > SynchronizationLib|zationLib.inf >> > >> > FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf >> > + >> > + CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull. >> > + inf >> > >> > >> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootM >> an >> > UefiBootManagerLib|agerLib.inf >> > >> > >> PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformB >> > PlatformBootManagerLib|ootManagerLib.inf >> > BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf >> > >> > >> >> Thanks Kalyan >> >> Could you resend it as a proper patch, please? I.e., with the appropriate >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> >> and Signed-off-by line, >> _______________________________________________ >> edk2-devel mailing list >> [email protected] >> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.01 >> .org%2Fmailman%2Flistinfo%2Fedk2- >> devel&data=02%7C01%7Cudit.kumar%40nxp.com%7Cc1807332add6499fcd730 >> 8d52b516fad%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6364625 >> 51151191358&sdata=joABHCm%2F3Iu0jfplBE3Ora9ffp3IfuNuu2GfOgOTsV8%3D >> &reserved=0 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
