Sorry just see this email. I just replied another one. Great to know it works for both of us.
> -----Original Message----- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, November 22, 2017 5:05 PM > To: Zeng, Star <star.z...@intel.com>; Wang, Jian J <jian.j.w...@intel.com> > Cc: edk2-devel@lists.01.org; Yao, Jiewen <jiewen....@intel.com> > Subject: Re: [edk2] [PATCH v7 0/2] Fix multiple entries of RT_CODE in memory > map > > On 11/22/17 08:56, Zeng, Star wrote: > > How about we have the v6 patch series in first with the feedback from Jiewen > (about comments) and you (about MemoryMapStart) addressed? > > > > Then we can have a separated patch for the merging. > > Good idea! > > Thanks! > Laszlo > > > > > > > > Thanks, > > Star > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > > Sent: Tuesday, November 21, 2017 9:38 PM > > To: Wang, Jian J <jian.j.w...@intel.com> > > Cc: edk2-devel@lists.01.org > > Subject: Re: [edk2] [PATCH v7 0/2] Fix multiple entries of RT_CODE in memory > map > > > > Jian, > > > > On 11/21/17 07:17, Jian J Wang wrote: > >>> v7: > >>> Merge memory map after filtering paging attributes > >> > >> More than one entry of RT_CODE memory might cause boot problem for > >> some old OSs. This patch will fix this issue to keep OS compatibility > >> as much as possible. > >> > >> Jian J Wang (2): > >> MdeModulePkg/DxeCore: Filter out all paging capabilities > >> UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map > >> > >> MdeModulePkg/Core/Dxe/DxeMain.h | 18 ++++++ > >> MdeModulePkg/Core/Dxe/Mem/Page.c | 21 +++++++ > >> MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c | 1 - > >> UefiCpuPkg/CpuDxe/CpuPageTable.c | 94 +++++++++++++++++++++-- > ----- > >> 4 files changed, 112 insertions(+), 22 deletions(-) > >> > > > > I don't have capacity to retest and re-review the series. > > > > Considering the following two options, I like none of them: > > > > (1) Version 7 is merged with my feedback tags from v6. I don't like this > > because > I didn't review or test version 7. > > > > (2) Version 7 is merged without my feedback tags. I don't like this because > > I've > put a lot of BZ writeup, and patch review and testing effort for this series, > and > I'd like the commit log to reflect that. > > > > > > Instead, I would like to request the following, for v8: > > > > Please submit a series that consists of three patches: > > > > - patch v8 1/3: identical to v6 1/2, except for the code comment update, > > - patch v8 2/3: identical to v6 2/2, > > - patch v8 3/3: please implement the merging of the memory map as a > separate patch. > > > > Patches v8 1/3 and 2/3 should include *both* my Tested-by *and* my > Reviewed-by tags, from v6. > > > > Patch v8 3/3 should be reviewed / tested separately by others. I don't > > think I > can find the capacity for that at the moment. > > > > This approach will correctly reflect all the work done thus far, and it will > provide the desired result for the code as well. > > > > Thanks > > Laszlo > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
