On 11/29/17 14:53, Laszlo Ersek wrote: > Ray, > > On 11/29/17 11:14, Ruiyu Ni wrote: >> The TFTP command was converted from a NULL class library >> instance to a dynamic shell command in commit 0961002352e9. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ruiyu Ni <[email protected]> >> Reviewed-by: Laszlo Ersek <[email protected]> >> Cc: Ard Biesheuvel <[email protected]> >> Cc: Julien Grall <[email protected]> >> --- >> ArmVirtPkg/ArmVirt.dsc.inc | 11 +++++++---- >> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 3 ++- >> ArmVirtPkg/ArmVirtXen.fdf | 3 ++- >> 3 files changed, 11 insertions(+), 6 deletions(-) > > Can you please incorporate points (2) and (3) as well, from my v3 review? > > https://lists.01.org/pipermail/edk2-devel/2017-November/018191.html
I fixed up the commit message as described above. I also test-built the ArmVirtQemu, ArmVirtQemuKernel and ArmVirtXen platforms, with the patch applied, for ARM and AARCH64. [[email protected]: extend commit message] Reviewed-by: Laszlo Ersek <[email protected]> Build-tested-by: Laszlo Ersek <[email protected]> Commit 59fcf0706bf4. Thanks Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
