On 2017.12.04 15:48, Gao, Liming wrote:
1. You add new build for ARM. I remember the reason is that --convert-hex
can't be used by trim for ARM ASM file. Right?
That is correct.
Maybe there's a better option to achieve just that, as duplicating the
whole section just to remove an option seems a bit of an overkill...
2. On tools_def.txt. Why introduce
/D_ARM_WINAPI_PARTITION_DESKTOP_SDK_AVAILABLE option?
The MSFT toolchain for ARM actively prevents compilation of native
applications, when using Microsoft headers, unless this value is
defined. If that is not the case, you get the error: "Compiling Desktop
applications for the ARM platform is not supported."
So this was needed when we were still using Microsoft headers for
stdarg.h, as compilation would break otherwise.
However, now that we are no longer relying on any standard headers from
the VS toolchain, I just confirmed that the option is no longer needed
(as the check for this definition is done in one of the Microsoft
headers, not the compiler).
I will therefore remove that option, as it is no longer needed.
Regards,
/Pete
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
