Hello Jian, On 12/12/17 04:28, Jian J Wang wrote: > The purpose of the patch is just to avoid complaining from compiler and > static check tool. > > Cc: Eric Dong <[email protected]> > Cc: Wu Hao <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jian J Wang <[email protected]> > --- > UefiCpuPkg/CpuDxe/CpuMp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/UefiCpuPkg/CpuDxe/CpuMp.c b/UefiCpuPkg/CpuDxe/CpuMp.c > index 56ba026152..61018c9950 100644 > --- a/UefiCpuPkg/CpuDxe/CpuMp.c > +++ b/UefiCpuPkg/CpuDxe/CpuMp.c > @@ -695,6 +695,8 @@ InitializeMpExceptionStackSwitchHandlers ( > EssData.Ia32.StackSwitchExceptionNumber = ExceptionNumber; > EssData.Ia32.KnownGoodStackSize = FixedPcdGet32(PcdCpuKnownGoodStackSize); > > + Gdtr.Base = 0; > + Gdtr.Limit = 0; > MpInitLibWhoAmI (&Bsp); > for (Index = 0; Index < mNumberOfProcessors; ++Index) { > // >
(1) Please add a separate comment, in the style that is described in <https://bugzilla.tianocore.org/show_bug.cgi?id=607>: // // set Gdtr to suppress incorrect compiler/analyzer warnings // Gdtr.Base = 0; Gdtr.Limit = 0; (2) I suggest updating the subject line like this: UefiCpuPkg/CpuDxe: suppress invalid warning about uninitialized variable (72 characters) With those changes: Reviewed-by: Laszlo Ersek <[email protected]> Thanks! Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
