Thanks for the fix. Star -----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of Laszlo Ersek Sent: Tuesday, December 12, 2017 9:10 PM To: Yao, Jiewen <[email protected]>; edk2-devel-01 <[email protected]> Cc: Dong, Eric <[email protected]>; Zeng, Star <[email protected]> Subject: Re: [edk2] [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error
On 12/12/17 13:54, Yao, Jiewen wrote: > Thanks ,Laszlo. > Reviewed-by: [email protected] Thanks! > Since it breaks the build, can we check in as soon as possible? Sure; commit dfc5a4dec602. Thanks! Laszlo >> -----Original Message----- >> From: edk2-devel [mailto:[email protected]] On Behalf >> Of Laszlo Ersek >> Sent: Tuesday, December 12, 2017 8:47 PM >> To: edk2-devel-01 <[email protected]> >> Cc: Dong, Eric <[email protected]>; Zeng, Star >> <[email protected]> >> Subject: [edk2] [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error >> >>> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c: In function >>> 'SmmReadyToBootHandler': >>> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c:323:14: error: passing >> argument >>> 3 of 'SmmLocateProtocol' from incompatible pointer type [-Werror] >>> ); >>> ^ >>> In file included from MdeModulePkg/Core/PiSmmCore/PiSmmCore.c:15:0: >>> MdeModulePkg/Core/PiSmmCore/PiSmmCore.h:586:1: note: expected 'void >> **' >>> but argument is of type 'struct EFI_SMM_SX_DISPATCH2_PROTOCOL **' >>> SmmLocateProtocol ( >>> ^ >>> cc1: all warnings being treated as errors >> >> Cc: Eric Dong <[email protected]> >> Cc: Star Zeng <[email protected]> >> Fixes: 7b9b55b2ef7be13608605dc58a54b9ca04be4e40 >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Laszlo Ersek <[email protected]> >> --- >> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >> b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >> index dbb89932e75b..1ccb9c7787ad 100644 >> --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >> +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >> @@ -319,7 +319,7 @@ SmmReadyToBootHandler ( >> Status = SmmLocateProtocol ( >> &gEfiSmmSxDispatch2ProtocolGuid, >> NULL, >> - &SxDispatch >> + (VOID **)&SxDispatch >> ); >> if (!EFI_ERROR (Status)) { >> // >> -- >> 2.14.1.3.gb7cf6e02401b >> >> _______________________________________________ >> edk2-devel mailing list >> [email protected] >> https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
