Reviewed-by: Jiaxin Wu <[email protected]>
> -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of Fu, > Siyuan > Sent: Wednesday, December 13, 2017 10:24 AM > To: [email protected] > Cc: Ye, Ting <[email protected]>; Wang, Fan <[email protected]>; Wu, > Jiaxin <[email protected]> > Subject: [edk2] [Patch] MdeModulePkg/Ip4Dxe: Remove redundant code in > Ip4Config2InitInstance(). > > Instance->Dhcp4Event is not necessary to be created in > Ip4Config2InitInstance. > Because it will created in Ip4StartAutoConfig() later. > > Cc: Ye Ting <[email protected]> > Cc: Wu Jiaxin <[email protected]> > Cc: Wang Fan <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Fu Siyuan <[email protected]> > --- > MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Impl.c | 12 ----------- > - > 1 file changed, 12 deletions(-) > > diff --git a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Impl.c > b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Impl.c > index 26530e3a2b..9925ae9203 100644 > --- a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Impl.c > +++ b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Impl.c > @@ -2034,18 +2034,6 @@ Ip4Config2InitInstance ( > DataItem->SetData = Ip4Config2SetDnsServer; > DataItem->Status = EFI_NOT_FOUND; > > - // > - // Create the event used for DHCP. > - // > - Status = gBS->CreateEvent ( > - EVT_NOTIFY_SIGNAL, > - TPL_CALLBACK, > - Ip4Config2OnDhcp4Event, > - Instance, > - &Instance->Dhcp4Event > - ); > - ASSERT_EFI_ERROR (Status); > - > Instance->Configured = TRUE; > > // > -- > 2.13.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
