On 22 December 2017 at 18:34, <evan.ll...@arm.com> wrote: > From: Girish Pathak <girish.pathak at arm.com> > > Minor code change, replaces magic number with macro in LCD disable. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Girish Pathak <girish.pat...@arm.com> > Signed-off-by: Evan Lloyd <evan.ll...@arm.com>
Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > --- > ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > index > 267c972bf795997f1df88b82acbaea5f75a7a00e..b236cbfcfffadd6fa7610dcae5c5bc748aac0f69 > 100644 > --- a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > +++ b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > @@ -117,8 +117,7 @@ LcdSetMode ( > } > > // Disable the CLCD_LcdEn bit > - LcdControl = MmioRead32 (PL111_REG_LCD_CONTROL); > - MmioWrite32 (PL111_REG_LCD_CONTROL, LcdControl & ~1); > + MmioAnd32 (PL111_REG_LCD_CONTROL, ~PL111_CTRL_LCD_EN); > > // Set Timings > MmioWrite32 ( > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel