Reviewed-by: Liming Gao <[email protected]> >-----Original Message----- >From: Wu, Hao A >Sent: Tuesday, December 19, 2017 11:29 AM >To: [email protected] >Cc: Wu, Hao A <[email protected]>; Gao, Liming <[email protected]>; >Zhu, Yonghong <[email protected]> >Subject: [PATCH 00/17] BaseTools/C: Code refinements > >The series refines the C/C++ source codes within BaseTools for the below >catagories: >* Resolve uninitialized: > Local variables and > Class variables in constructor > >* Add/refine boundary checks when accessing (string) buffers. > >* Add/refine status checks for the usage of file handles > >* Remove redundant explicit type casts > >* Resolve possible resource/memory leaks > >* Resolve possible NULL pointer dereferences > >Cc: Liming Gao <[email protected]> >Cc: Yonghong Zhu <[email protected]> > >Hao Wu (17): > BaseTools/C/Common: Add checks for array access > BaseTools/EfiRom: Refine the logic in main() > BaseTools/LzmaCompress: Fix possible uninitialized variable > BaseTools/C/Common: Remove redundant type cast > BaseTools/VfrCompile: Assign 'NULL' for closed file handle > BaseTools/GenFv: Add check to ensure the file handle status is correct > BaseTools/C/Common: Add/refine boundary checks for strcpy/strcat calls > BaseTools/C/Common: Refine using sprintf() with '%s' in format string > BaseTools/EfiRom: Add/refine boundary checks for strcpy/strcat calls > BaseTools/GenBootSector: Add/refine boundary checks for strcpy/strcat > BaseTools/GenFv: Add/refine boundary checks for strcpy/strcat calls > BaseTools/GenVtf: Add/refine boundary checks for strcpy/strcat calls > BaseTools/VfrCompile: Add/refine boundary checks for strcpy/strcat > BaseTools/VfrCompile: Resolve uninit class variables in constructor > BaseTools/GenFfs: Enlarge the size of 'AlignmentBuffer' > BaseTools/GenSec: Fix potential memory leak > BaseTools/GenSec: Fix potential null pointer dereference > > BaseTools/Source/C/Common/BasePeCoff.c | 12 +++---- > BaseTools/Source/C/Common/CommonLib.c | 24 +++++++++---- > BaseTools/Source/C/Common/Decompress.c | 8 ++--- > BaseTools/Source/C/Common/EfiUtilityMsgs.c | 30 ++++++++--------- > BaseTools/Source/C/Common/SimpleFileParsing.c | 12 +++---- > BaseTools/Source/C/EfiRom/EfiRom.c | 20 +++++++---- > BaseTools/Source/C/GenBootSector/GenBootSector.c | 17 ++++++++-- > BaseTools/Source/C/GenFfs/GenFfs.c | 7 +++- > BaseTools/Source/C/GenFv/GenFv.c | 38 +++++++++++---------- > BaseTools/Source/C/GenFv/GenFvInternalLib.c | 26 +++++++++++--- > BaseTools/Source/C/GenSec/GenSec.c | 22 +++++++++++- > BaseTools/Source/C/GenVtf/GenVtf.c | 43 ++++++++++++++++++++- >--- > BaseTools/Source/C/LzmaCompress/Sdk/C/7zFile.c | 2 +- > BaseTools/Source/C/VfrCompile/VfrCompiler.cpp | 3 +- > BaseTools/Source/C/VfrCompile/VfrError.cpp | 1 + > BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp | 6 ++++ > BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp | 17 +++++++--- > 17 files changed, 204 insertions(+), 84 deletions(-) > >-- >2.12.0.windows.1
_______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
