On 27 December 2017 at 08:53, Long, Qin <qin.l...@intel.com> wrote: > Thanks, Ard. > Reviewed-by: Long Qin <qin.l...@intel.com> >
Thanks. Pushed as 08ba82934ebd > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard > Biesheuvel > Sent: Wednesday, December 27, 2017 4:05 PM > To: edk2-devel@lists.01.org; Long, Qin <qin.l...@intel.com>; Ye, Ting > <ting...@intel.com> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Subject: [edk2] [PATCH] CryptoPkg/OpensslLib AARCH64: suppress format string > warning > > On GCC Build: openssl-1.1.0g introduced one additional build warning: > ...\openssl\crypto\asn1\x_int64.c:105:32: error: format '%ld' expects > argument of type 'long int', but argument 3 has type 'int64_t > {aka long long int}' [-Werror=format=] return BIO_printf(out, > "%"BIO_PRI64"d\n", **(int64_t **)pval); > ^ > Add "-Wno-error=format" to GCC build flags to suppress this warning, since we > have no real printf usage in BaseCryptLib, and BIO_printf() was already > wrapped as a dummy implementation in CryptoPkg. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > --- > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 +- > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > index 5302ad7fb5ef..602953eefff7 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > @@ -560,7 +560,7 @@ [BuildOptions] > GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) > -Wno-error=maybe-uninitialized -Wno-error=format -DNO_MSABI_VA_FUNCS > GCC:*_*_IPF_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) > -Wno-error=maybe-uninitialized -Wno-error=format > GCC:*_*_ARM_CC_FLAGS = $(OPENSSL_FLAGS) > - GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) > + GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=format > > # suppress the following warnings in openssl so we don't break the build > with warnings-as-errors: > # 1295: Deprecated declaration <entity> - give arg types diff --git > a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > index 0c7f9e9e66f4..f697243f9787 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > @@ -521,7 +521,7 @@ [BuildOptions] > GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) > -Wno-error=maybe-uninitialized -Wno-error=format -DNO_MSABI_VA_FUNCS > GCC:*_*_IPF_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) > -Wno-error=maybe-uninitialized -Wno-error=format > GCC:*_*_ARM_CC_FLAGS = $(OPENSSL_FLAGS) > - GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) > + GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=format > > # suppress the following warnings in openssl so we don't break the build > with warnings-as-errors: > # 1295: Deprecated declaration <entity> - give arg types > -- > 2.11.0 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
