Jian: I prefer to roll back this change. So, the definition in BaseLib.h can be kept in the same style.
Thanks Liming >-----Original Message----- >From: edk2-devel [mailto:[email protected]] On Behalf Of >Wang, Jian J >Sent: Wednesday, December 27, 2017 8:40 AM >To: Kinney, Michael D <[email protected]>; edk2- >[email protected] >Subject: Re: [edk2] [PATCH 0/4] Coding style clean-up > >Hi Mike, > >Since this patch has been checked in trunk, do you think it should be reverted? >In addition, instead of using exception list for the ECC tool, I think it'd be >better >to update ECC tool to use keyword match to check if a field name is public >spec >defined one. Otherwise, if there's new structure type using those field names, >the tool will still report errors. > >Regards, >Jian > >> -----Original Message----- >> From: Kinney, Michael D >> Sent: Wednesday, December 27, 2017 12:48 AM >> To: Wang, Jian J <[email protected]>; [email protected]; Kinney, >> Michael D <[email protected]> >> Subject: RE: [edk2] [PATCH 0/4] Coding style clean-up >> >> Jian, >> >> I do not think this change should be made. >> >> One of the exceptions for not following the >> EDK II code style is if the field names are >> defined in a public specification. In this case >> these fields are all listed in a structure in >> the Intel 64 and IA-32 Architectures Software >> Development Manual, Section 7.2.1, Figure 7-2 >> using upper case register names. >> >> Thanks, >> >> Mike >> >> >> >> > -----Original Message----- >> > From: edk2-devel [mailto:[email protected]] >> > On Behalf Of Jian J Wang >> > Sent: Sunday, December 24, 2017 5:07 PM >> > To: [email protected] >> > Subject: [edk2] [PATCH 0/4] Coding style clean-up >> > >> > This patch series are meant for cleaning up code >> > according to coding style >> > requirements. >> > >> > Jian J Wang (4): >> > MdePkg/BaseLib.h: Coding style clean-up >> > MdeModulePkg/Core: Coding style clean-up >> > UefiCpuPkg/UefiCpuPkg.uni: Add missing string >> > definition for new PCDs >> > UefiCpuPkg: Update code to use new structure field >> > names >> > >> > MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c | 5 >> > ++ >> > MdePkg/Include/Library/BaseLib.h | 72 >> > +++++++++++----------- >> > .../Ia32/ArchExceptionHandler.c | 24 >> > ++++---- >> > .../X64/ArchExceptionHandler.c | 6 >> > +- >> > UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 >> > +- >> > UefiCpuPkg/UefiCpuPkg.uni | 16 >> > ++++- >> > 6 files changed, 71 insertions(+), 54 deletions(-) >> > >> > -- >> > 2.15.1.windows.2 >> > >> > _______________________________________________ >> > edk2-devel mailing list >> > [email protected] >> > https://lists.01.org/mailman/listinfo/edk2-devel >_______________________________________________ >edk2-devel mailing list >[email protected] >https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
