On 27 December 2017 at 13:02, Vabhav Sharma <vabhav.sha...@nxp.com> wrote: > > >>-----Original Message----- >>From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >>Sent: Friday, December 22, 2017 9:04 PM >>To: Vabhav Sharma <vabhav.sha...@nxp.com> >>Cc: Leif Lindholm <leif.lindh...@linaro.org>; Kinney, Michael D >><michael.d.kin...@intel.com>; edk2-devel@lists.01.org; Udit Kumar >><udit.ku...@nxp.com>; Varun Sethi <v.se...@nxp.com> >>Subject: Re: [PATCH edk2-platforms 0/3] Platform/NXP-Added NXP PCI Host >>Bridge Driver >> >>On 21 December 2017 at 18:48, Vabhav <vabhav.sha...@nxp.com> wrote: >>> Following patches will add support of NXP PCI Host Bridge Driver in edk2- >>platforms directory 'edk2-platforms/Platform/NXP' >>> >> >>Why do you need a new PciHostBridgeDxe driver? Can't you use the one in >>MdeModulePkg instead? > Using PciHostbridge dxe driver with changes for multiple(three) host bridge > instances with 1:1 mapping for HostBridge:Root bridge(Hb:Rb), I will > evaluate MdeModulePkg for > Multiple host bridge support
You will need to re-implement PciSegmentLib for that. Please find an example here: https://git.linaro.org/leg/noupstream/edk2-platforms.git/tree/Silicon/Socionext/SynQuacer/Library/SynQuacerPciSegmentLib?h=developer-box >> >>> Updated Directory structure for added folders in 'edk2- >>platforms/Platform/NXP' will be: >>> >>> Platform/NXP/Drivers/PciHostBridgeDxe/ >>> |-- PciHostBridgeDxe.c >>> |-- PciHostBridgeDxe.inf >>> `-- PciRootBridgeIo.c >>> >>> Platform/NXP/Library/PciHostBridgeLib/ >>> |-- PciCntrl.c >>> |-- PciHostBridgeLib.inf >>> `-- PciRbLib.c >>> >> >>Please put these in Silicon/NXP, not Platform/NXP > Reference is taken from ARM/Hisilicon directory structure , We plan to put > only chassis specific code in Silicon/NXP and Drivers, Library in > Platform/NXP. > Please suggest if there is any specific reason for putting them in > Silicon/NXP? Yes. Platform/ contains platform specific pieces, e.g., board level driver, device tree images, .DSC files etc. Libraries and drivers that can be shared between different platforms using the same SoC belong in Silicon/NXP. >> >>> In Platform/NXP/Library >>> PciHostBridgeLib librady is added >>> >>> In Platform/NXP/Drivers: >>> PciHostBridgeDxe driver is added >>> >>> Please review and look forward for your support in upstreaming the patches >>> in >>edk2-platforms. >>> >>> Vabhav (3): >>> Platform/NXP : Add PCI Host Bridge Libary >>> Platform/NXP : Add PCI Host Bridge Driver >>> Compilation:Modify dsc,fdf files >>> >>> .../Drivers/PciHostBridgeDxe/PciHostBridgeDxe.c | 967 ++++++++++++++++ >>> .../Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf | 61 + >>> .../NXP/Drivers/PciHostBridgeDxe/PciRootBridgeIo.c | 1193 >>++++++++++++++++++++ >>> Platform/NXP/Include/PciCntrlLib.h | 323 ++++++ >>> Platform/NXP/Include/PciHostBridge.h | 466 ++++++++ >>> Platform/NXP/Include/PciLib.h | 414 +++++++ >>> Platform/NXP/Include/PciRootBridge.h | 674 +++++++++++ >>> Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 31 + >>> Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 6 + >>> Platform/NXP/Library/PciHostBridgeLib/PciCntrl.c | 628 +++++++++++ >>> .../Library/PciHostBridgeLib/PciHostBridgeLib.inf | 49 + >>> Platform/NXP/Library/PciHostBridgeLib/PciRbLib.c | 331 ++++++ >>> Silicon/NXP/Chassis/Chassis.c | 11 + >>> Silicon/NXP/Chassis/Chassis2/SerDes.h | 11 + >>> Silicon/NXP/LS1043A/LS1043A.dsc | 1 + >>> 15 files changed, 5166 insertions(+) >>> create mode 100644 >>> Platform/NXP/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.c >>> create mode 100644 >>> Platform/NXP/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf >>> create mode 100644 >>> Platform/NXP/Drivers/PciHostBridgeDxe/PciRootBridgeIo.c >>> create mode 100644 Platform/NXP/Include/PciCntrlLib.h >>> create mode 100644 Platform/NXP/Include/PciHostBridge.h >>> create mode 100644 Platform/NXP/Include/PciLib.h create mode 100644 >>> Platform/NXP/Include/PciRootBridge.h >>> create mode 100644 Platform/NXP/Library/PciHostBridgeLib/PciCntrl.c >>> create mode 100644 >>> Platform/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.inf >>> create mode 100644 Platform/NXP/Library/PciHostBridgeLib/PciRbLib.c >>> >>> -- >>> 1.9.1 >>> _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
