Ard: How about introduce DTC_FLAGS in tools_def.txt? It can avoid the future change in build_rule.txt.
Thanks Liming >-----Original Message----- >From: Laszlo Ersek [mailto:[email protected]] >Sent: Saturday, January 06, 2018 4:20 AM >To: Ard Biesheuvel <[email protected]>; [email protected]; >Gao, Liming <[email protected]> >Subject: Re: [edk2] [PATCH] BaseTools/build_rule: disable DTC legacy phandle >format > >On 01/05/18 10:36, Ard Biesheuvel wrote: >> By default, the device tree compiler emits phandle properties twice: >> one called 'phandle' and another called 'linux,phandle'. Given that >> Linux was updated in early 2010 [0] to accept the former (which is >> what is specified in the ePAPR and device tree specifications), there >> is no point in emitting both when compiling device trees for UEFI >> platforms. >> >> [0] 04b954a673dd02f585a2769c4945a43880faa989 >> "of/flattree: Make the kernel accept ePAPR style phandle information" >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel <[email protected]> >> --- >> BaseTools/Conf/build_rule.template | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/BaseTools/Conf/build_rule.template >b/BaseTools/Conf/build_rule.template >> index 3e6aa8ff0f34..10a91fe3a6c6 100755 >> --- a/BaseTools/Conf/build_rule.template >> +++ b/BaseTools/Conf/build_rule.template >> @@ -250,7 +250,7 @@ >> >> <Command.GCC> >> "$(PP)" $(DTCPP_FLAGS) $(INC) ${src} > ${d_path}(+)${s_base}.i >> - "$(DTC)" -I dts -O dtb -o ${dst} ${d_path}(+)${s_base}.i >> + "$(DTC)" -H epapr -I dts -O dtb -o ${dst} ${d_path}(+)${s_base}.i >> >> [Visual-Form-Representation-File] >> <InputFile> >> > >[0] is part of Linux v2.6.34 :) > >Reviewed-by: Laszlo Ersek <[email protected]> > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
