So, I'm mostly happy with this set, but:

Sender (and hence Author for all patches that do not have a second
From: statement after Subject: ) for all patches here is
Ming Huang <[email protected]>

Can you please address this, either by actually sending from Ming Huang, or
by adding a From:.

You can add my
Reviewed-by: Leif Lindholm <[email protected]>
to 3-4, 6-12 and 15.

I have a few comments on 5/15, and then I need some input from others
on the ACPI bits - especially from Jeremy, who should ideally have
been cc:d on at least the PPTT patch given his comments on v1.

/
    Leif

On Fri, Jan 26, 2018 at 04:00:35PM +0800, Ming Huang wrote:
> The major features of this patchset include
> adding PPTT support, 
> switching to Generic BDS driver,
> adding capsule upgrade support,
> open-source version for SnpPlatform and SasPlatform
> changing DmaLib to CoherentDmaLib(this one is omissive in v1).
> 
> Code can also be found in github: 
> https://github.com/hisilicon/OpenPlatformPkg.git
> branch: rp-1802-platforms-v2
> 
> 
> Jason Zhang (3):
>   Hisilicon D03/D05: Add capsule upgrade support
>   Hisilicon D03/D05: Open SasPlatform source code
>   Hisilicon D03/D05: Open SnpPlatform source code
> 
> Ming Huang (11):
>   Hisilicon/D05: Move Madt definition to head file
>   Hisilicon/D05: Add PPTT support
>   Hisilicon/D0x/BDS: Switch to Generic BDS driver
>   Hisilicon/D0x: Break BMC SetBoot option out into separate library
>   Hilisicon: Change DmaLib to CoherentDmaLib
>   Hisilicon/Smbios: Indicate use of ProcessorFamily2 in type 4 table
>   Hisilicon/D05: Replace SP805Watchdog by WatchdogTimer driver.
>   Hisilicon/D03: Replace SP805Watchdog by WatchdogTimer driver.
>   Hisilicon/D05/ACPI: Add ITS PXM
>   Hisilicon/D05/ACPI: Add Pcie, HNS and SAS PXM
>   Hisilicon D03/D05: Update firmware version to 18.02
> 
> Yan Zhang (1):
>   Hisilicon/PCIe: Disable PCIe ASPM
> 
>  
> Platform/Hisilicon/D03/Capsule/SystemFirmwareUpdateConfig/SystemFirmwareUpdateConfig.ini
>  |  45 ++
>  Platform/Hisilicon/D03/D03.dsc                                               
>             |  42 +-
>  Platform/Hisilicon/D03/D03.fdf                                               
>             |  79 ++-
>  
> Platform/Hisilicon/D03/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc
>     |  81 +++
>  
> Platform/Hisilicon/D03/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf
>      |  50 ++
>  
> Platform/Hisilicon/D03/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptorPei.c
>     |  70 +++
>  
> Platform/Hisilicon/D05/Capsule/SystemFirmwareUpdateConfig/SystemFirmwareUpdateConfig.ini
>  |  45 ++
>  Platform/Hisilicon/D05/D05.dsc                                               
>             |  47 +-
>  Platform/Hisilicon/D05/D05.fdf                                               
>             |  80 ++-
>  
> Platform/Hisilicon/D05/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc
>     |  81 +++
>  
> Platform/Hisilicon/D05/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf
>      |  50 ++
>  
> Platform/Hisilicon/D05/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptorPei.c
>     |  70 +++
>  Silicon/Hisilicon/Drivers/SasPlatform/SasPlatform.c                          
>             | 106 ++++
>  Silicon/Hisilicon/Drivers/SasPlatform/SasPlatform.inf                        
>             |  45 ++
>  Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c    
>             |   4 +-
>  Silicon/Hisilicon/Drivers/SnpPlatform/SnpPlatform.c                          
>             | 115 ++++
>  Silicon/Hisilicon/Drivers/SnpPlatform/SnpPlatform.inf                        
>             |  46 ++
>  Silicon/Hisilicon/Drivers/VirtualEhciPciIo/VirtualEhciPciIo.c                
>             |   2 +-
>  Silicon/Hisilicon/Hi1610/Drivers/IoInitDxe/IoInitDxe.c                       
>             |   3 +-
>  Silicon/Hisilicon/Hi1610/Drivers/PcieInit1610/PcieInitLib.c                  
>             | 103 ++++
>  Silicon/Hisilicon/Hi1610/Drivers/PcieInit1610/PcieInitLib.h                  
>             |   2 +
>  Silicon/Hisilicon/Hi1616/D05AcpiTables/D05Srat.aslc                          
>             |  10 +
>  Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Hns.asl                       
>             |   9 +
>  Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Pci.asl                       
>             |  34 +-
>  Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl                       
>             |  19 +-
>  Silicon/Hisilicon/Hi1616/D05AcpiTables/Hi1616Platform.h                      
>             |  30 +-
>  Silicon/Hisilicon/Hi1616/D05AcpiTables/MadtHi1616.aslc                       
>             |  23 +-
>  Silicon/Hisilicon/Hi1616/Pptt/Pptt.c                                         
>             | 540 ++++++++++++++++
>  Silicon/Hisilicon/Hi1616/Pptt/Pptt.h                                         
>             |  88 +++
>  Silicon/Hisilicon/Hi1616/Pptt/Pptt.inf                                       
>             |  48 ++
>  Silicon/Hisilicon/HisiPkg.dec                                                
>             |   6 +
>  Silicon/Hisilicon/Hisilicon.dsc.inc                                          
>             |  12 +-
>  Silicon/Hisilicon/Hisilicon.fdf.inc                                          
>             |   9 +
>  Silicon/Hisilicon/Include/Library/AcpiNextLib.h                              
>             |  10 +-
>  Silicon/Hisilicon/Include/Library/BmcConfigBootLib.h                         
>             |  31 +
>  Silicon/Hisilicon/Include/Library/OemDevicePath.h                            
>             |  52 ++
>  Silicon/Hisilicon/Include/Protocol/HisiPlatformSasProtocol.h                 
>             |  30 +
>  Silicon/Hisilicon/Include/Protocol/SnpPlatformProtocol.h                     
>             |  32 +
>  Silicon/Hisilicon/Include/Regs/HisiPcieV1RegOffset.h                         
>             |   2 +
>  Silicon/Hisilicon/Library/BmcConfigBootLib/BmcConfigBootLib.c                
>             | 466 ++++++++++++++
>  Silicon/Hisilicon/Library/BmcConfigBootLib/BmcConfigBootLib.inf              
>             |  51 ++
>  Silicon/Hisilicon/Library/PlatformBootManagerLib/PlatformBm.c                
>             | 643 ++++++++++++++++++++
>  Silicon/Hisilicon/Library/PlatformBootManagerLib/PlatformBm.h                
>             |  31 +
>  Silicon/Hisilicon/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf  
>             |  74 +++
>  Silicon/Hisilicon/Library/PlatformFlashAccessLib/PlatformFlashAccessLibDxe.c 
>             | 123 ++++
>  
> Silicon/Hisilicon/Library/PlatformFlashAccessLib/PlatformFlashAccessLibDxe.inf
>            |  51 ++
>  46 files changed, 3536 insertions(+), 54 deletions(-)
>  create mode 100644 
> Platform/Hisilicon/D03/Capsule/SystemFirmwareUpdateConfig/SystemFirmwareUpdateConfig.ini
>  create mode 100644 
> Platform/Hisilicon/D03/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc
>  create mode 100644 
> Platform/Hisilicon/D03/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf
>  create mode 100644 
> Platform/Hisilicon/D03/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptorPei.c
>  create mode 100644 
> Platform/Hisilicon/D05/Capsule/SystemFirmwareUpdateConfig/SystemFirmwareUpdateConfig.ini
>  create mode 100644 
> Platform/Hisilicon/D05/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc
>  create mode 100644 
> Platform/Hisilicon/D05/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf
>  create mode 100644 
> Platform/Hisilicon/D05/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptorPei.c
>  create mode 100644 Silicon/Hisilicon/Drivers/SasPlatform/SasPlatform.c
>  create mode 100644 Silicon/Hisilicon/Drivers/SasPlatform/SasPlatform.inf
>  create mode 100644 Silicon/Hisilicon/Drivers/SnpPlatform/SnpPlatform.c
>  create mode 100644 Silicon/Hisilicon/Drivers/SnpPlatform/SnpPlatform.inf
>  create mode 100644 Silicon/Hisilicon/Hi1616/Pptt/Pptt.c
>  create mode 100644 Silicon/Hisilicon/Hi1616/Pptt/Pptt.h
>  create mode 100644 Silicon/Hisilicon/Hi1616/Pptt/Pptt.inf
>  create mode 100644 Silicon/Hisilicon/Include/Library/BmcConfigBootLib.h
>  create mode 100644 Silicon/Hisilicon/Include/Library/OemDevicePath.h
>  create mode 100644 
> Silicon/Hisilicon/Include/Protocol/HisiPlatformSasProtocol.h
>  create mode 100644 Silicon/Hisilicon/Include/Protocol/SnpPlatformProtocol.h
>  create mode 100644 
> Silicon/Hisilicon/Library/BmcConfigBootLib/BmcConfigBootLib.c
>  create mode 100644 
> Silicon/Hisilicon/Library/BmcConfigBootLib/BmcConfigBootLib.inf
>  create mode 100644 
> Silicon/Hisilicon/Library/PlatformBootManagerLib/PlatformBm.c
>  create mode 100644 
> Silicon/Hisilicon/Library/PlatformBootManagerLib/PlatformBm.h
>  create mode 100644 
> Silicon/Hisilicon/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
>  create mode 100644 
> Silicon/Hisilicon/Library/PlatformFlashAccessLib/PlatformFlashAccessLibDxe.c
>  create mode 100644 
> Silicon/Hisilicon/Library/PlatformFlashAccessLib/PlatformFlashAccessLibDxe.inf
> 
> -- 
> 1.9.1
> 
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to