On 31 January 2018 at 10:39, Zhu, Yonghong <[email protected]> wrote:
> Reviewed-by: Yonghong Zhu <[email protected]>
>
This patch breaks the GCC build.
PcdValueCommon.c: In function '__PcdGetPtr':
PcdValueCommon.c:315:11: error: variable 'Byte' set but not used
[-Werror=unused-but-set-variable]
UINT8 Byte;
^~~~
> -----Original Message-----
> From: edk2-devel [mailto:[email protected]] On Behalf Of Liming
> Gao
> Sent: Wednesday, January 31, 2018 5:04 PM
> To: [email protected]
> Subject: [edk2] [Patch] BaseTools CommonLib: Remove the unnecessary print
> message in PcdValueCommon
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <[email protected]>
> ---
> BaseTools/Source/C/Common/PcdValueCommon.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/BaseTools/Source/C/Common/PcdValueCommon.c
> b/BaseTools/Source/C/Common/PcdValueCommon.c
> index 92328da..210f87b 100644
> --- a/BaseTools/Source/C/Common/PcdValueCommon.c
> +++ b/BaseTools/Source/C/Common/PcdValueCommon.c
> @@ -330,9 +330,7 @@ Returns:
> break;
> case PcdDataTypePointer:
> Value = &PcdList[Index].Value[1];
> - printf ("Value = %s\n", PcdList[Index].Value);
> for (*Size = 0, Byte = (UINT8) strtoul(Value, &End, 16); Value != End;
> Byte = (UINT8) strtoul(Value, &End, 16), *Size = *Size + 1) {
> - printf("%x\n", Byte);
> Value = End + 1;
> }
> Buffer = malloc(*Size + 1);
> @@ -401,7 +399,6 @@ Returns:
> PcdList[Index].Value = malloc(Size * 5 + 3);
> PcdList[Index].Value[0] = '{';
> for (ValueIndex = 0; ValueIndex < Size; ValueIndex++) {
> - printf("Value[%d] = %02x\n", ValueIndex, Value[ValueIndex]);
> sprintf(&PcdList[Index].Value[1 + ValueIndex * 5], "0x%02x,",
> Value[ValueIndex]);
> }
> PcdList[Index].Value[1 + Size * 5 - 1] = '}'; @@ -724,15 +721,11 @@
> Returns:
> if (*InputFileName == NULL) {
> fprintf (stderr, "Missing option. Input files is not specified\n");
> exit (EXIT_FAILURE);
> - } else {
> - printf ("Input file name is %s\n", *InputFileName);
> }
>
> if (*OutputFileName == NULL) {
> fprintf (stderr, "Missing option. Output file is not specified\n");
> exit (EXIT_FAILURE);
> - } else {
> - printf ("Output file name is %s\n", *OutputFileName);
> }
> }
>
> @@ -761,7 +754,6 @@ Returns:
> UINT8 *FileBuffer;
> UINT32 FileSize;
>
> - printf ("PCD tool start.\n");
> InputFileName = NULL;
> OutputFileName = NULL;
>
> @@ -790,7 +782,5 @@ Returns:
> //
> WriteOutputFile (OutputFileName);
>
> - printf ("PCD tool done.\n");
> -
> exit (EXIT_SUCCESS);
> }
> --
> 2.8.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> [email protected]
> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> [email protected]
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
