Hi Laszlo, Thanks for your comments. I will update the commit message.
Regards, Dandan -----Original Message----- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, February 7, 2018 4:17 PM To: Zeng, Star <star.z...@intel.com>; Bi, Dandan <dandan...@intel.com>; edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com> Subject: Re: [patch] MdeModulePkg/PciBusDxe: Fix VS2012 build failure On 02/07/18 02:44, Zeng, Star wrote: > Reviewed-by: Star Zeng <star.z...@intel.com> > > Cc Laszlo. Thanks! > You can add similar comment like 1ea53108f6c1010a00a828d1d59ea28934025415 as > recommended by https://bugzilla.tianocore.org/show_bug.cgi?id=607. Yes, that would be nice. The patch looks correct. Dandan, can you please add the following to the commit message too: ---- Both reads (dereferences) of "PciRootBridgeIo" in PciBusDriverBindingStart() are only reached if "gFullEnumeration" is TRUE on entry *and* we successfully open the EfiPciRootBridgeIoProtocol interface. ---- With that: Reviewed-by: Laszlo Ersek <ler...@redhat.com> Thanks! Laszlo > Thanks, > Star > -----Original Message----- > From: Bi, Dandan > Sent: Wednesday, February 7, 2018 9:31 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com> > Subject: [patch] MdeModulePkg/PciBusDxe: Fix VS2012 build failure > > Initialize local variable to suppress warning C4703: > potentially uninitialized local pointer variable. > > Cc: Star Zeng <star.z...@intel.com> > Cc: Ruiyu Ni <ruiyu...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi <dandan...@intel.com> > --- > MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c > index c48e3bb..13221b9 100644 > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c > @@ -242,10 +242,12 @@ PciBusDriverBindingStart ( { > EFI_STATUS Status; > EFI_DEVICE_PATH_PROTOCOL *ParentDevicePath; > EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL *PciRootBridgeIo; > > + PciRootBridgeIo = NULL; > + > // > // Check RemainingDevicePath validation > // > if (RemainingDevicePath != NULL) { > // > -- > 1.9.5.msysgit.1 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
