On 7 February 2018 at 01:29, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Mon, Feb 05, 2018 at 04:25:52PM +0800, Haojian Zhuang wrote: >> Add skeleton of HiKey960 platform. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> >> --- >> + gEmbeddedTokenSpaceGuid.PcdEmbeddedScriptCmd|FALSE >> + >> + gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE > > The above Pcds are all obsolete. > Seeing this patch made me go through and clean up EmbeddedPkg and > platform templates. > > Could you generate a new version of this patch that applies and builds > cleanly against the cleanup series I just posted to edk2-devel?: > https://git.linaro.org/people/leif.lindholm/edk2.git/log/?h=embeddedpkg-cleanup > and > https://git.linaro.org/people/leif.lindholm/edk2-platforms.git/log/?h=embeddedpkg-cleanup >
OK. I'll rebase on it. > (I would be even happier if you could break the common parts of > Hikey/Hikey960 descriptions into a common .dsc, like the d02,3,5 > platforms do with Silicon/Hisilicon/Hisilicon.dsc.inc.) > OK. Best Regards Haojian _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
