Reviewed-by: Jaben Carsey <[email protected]>
> -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of > Laszlo Ersek > Sent: Wednesday, February 07, 2018 2:45 PM > To: [email protected] > Cc: Ni, Ruiyu <[email protected]>; Brijesh Singh <[email protected]>; > Ard Biesheuvel <[email protected]>; Justen, Jordan L > <[email protected]>; Gary Lin <[email protected]>; Carsey, Jaben > <[email protected]> > Subject: [edk2] [PATCH v2 0/2] sync some function definitions with their > declarations > Importance: High > > Repo: https://github.com/lersek/edk2.git > Branch: sync_defs_to_decls_v2 > > This is version 2 of the series that I posted earlier. Because that > series didn't reach the list at all, due to SMTP issues on my end, I'm > including the v1 blurb here: > > > The patches say it all, just a side remark up here: > > > > These errors would have been caught long ago if we had enabled the > > "-Wmissing-prototypes" gcc option. > > > > (Unfortunately, we can't enable that option even now, because it -- > > laudably -- forces the programmer to give internal linkage ("STATIC") > > to their helper / local functions, and -- as we've learned -- some > > versions of the the Visual Studio debugger choke on STATIC functions. > > Thus, core modules basically never make their internal functions > > STATIC.) > > The v2 changes are noted per patch. > > (This posting should hopefully reach the list; while the original SMTP > issue remains undiagnosed, I attempted to put a work-around in place. > Let's see if it works.) > > Cc: Ard Biesheuvel <[email protected]> > Cc: Brijesh Singh <[email protected]> > Cc: Gary Lin <[email protected]> > Cc: Jaben Carsey <[email protected]> > Cc: Jordan Justen <[email protected]> > Cc: Ruiyu Ni <[email protected]> > > Thanks, > Laszlo > > Laszlo Ersek (2): > ShellPkg/UefiShellDebug1CommandsLib: sync Compress() definition with > decl. > OvmfPkg/PlatformPei: sync AmdSevInitialize() definition with > declaration > > OvmfPkg/PlatformPei/AmdSev.c | 3 ++- > ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.c | 14 > ++++++++------ > ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h | 1 - > 3 files changed, 10 insertions(+), 8 deletions(-) > > -- > 2.14.1.3.gb7cf6e02401b > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
