Thank you star. I will update them before committing the patches. Thanks, Dandan
-----Original Message----- From: Zeng, Star Sent: Friday, February 9, 2018 4:31 PM To: Bi, Dandan <dandan...@intel.com>; edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com>; Dong, Eric <eric.d...@intel.com>; Gao, Liming <liming....@intel.com>; Laszlo Ersek <ler...@redhat.com>; Wei, David <david....@intel.com>; Zeng, Star <star.z...@intel.com> Subject: RE: [edk2] [PATCH v2 0/7] Remove the useless pref codes Hi Dandan, Two minor comments, with them handled, Reviewed-by: Star Zeng <star.z...@intel.com> to the patch series. :) 1. Put the first patch to the last patch as it is to remove the definition and should be done at last. 2. Fix typo 'pref' to 'perf', and 'new new' to 'new'. Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Friday, February 9, 2018 4:05 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com>; Dong, Eric <eric.d...@intel.com>; Gao, Liming <liming....@intel.com>; Laszlo Ersek <ler...@redhat.com>; Zeng, Star <star.z...@intel.com>; Wei, David <david....@intel.com> Subject: [edk2] [PATCH v2 0/7] Remove the useless pref codes V2: a. Remove defintions related to old perf code and clean all useless perf codes in edk2 code base. b.Update commit message. Our new performance infrastructure (edk2 trunk commit hash value: SHA-1: 73fef64f14d1b97ae9bd4705df3becc022391eba ~ SHA-1: 115eae650bfd2be2c2bc37360f4a755065e774c4) can support to dump performance date form ACPI table in OS. So we can remove the old pref code to write performance data to OS and related definitions. Cc: Star Zeng <star.z...@intel.com> Cc: Liming Gao <liming....@intel.com> Cc: Ruiyu Ni <ruiyu...@intel.com> Cc: Eric Dong <eric.d...@intel.com> Cc: Laszlo Ersek <ler...@redhat.com> Cc: David Wei <david....@intel.com> Cc: Mang Guo <mang....@intel.com> Dandan Bi (7): MdeModulePkg/Performance.h: Remove the useless definition UefiCpuPkg/S3Resume: Remove useless pref code MdeModulePkg/BdsDxe: Remove useless Pref Code MdeModulePkg/UefiBootManagerLib: Remove the useless pref codes IntelFrameworkModulePkg/BdsDxe: Remove the useless Perf codes IntelFrameworkModulePkg/GenericBdsLib: Remove the useless Perf codes Vlv2TbltDevicePkg/Override/GenericBdsLib:Remove useless Perf code .../Library/GenericBdsLib/BdsBoot.c | 29 +- .../Library/GenericBdsLib/GenericBdsLib.inf | 4 +- .../Library/GenericBdsLib/InternalBdsLib.h | 19 +- .../Library/GenericBdsLib/Performance.c | 313 ------------------ IntelFrameworkModulePkg/Universal/BdsDxe/Bds.h | 3 +- .../Universal/BdsDxe/BdsDxe.inf | 3 +- .../Universal/BdsDxe/BdsEntry.c | 57 +--- MdeModulePkg/Include/Guid/Performance.h | 27 +- MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 27 +- .../Library/UefiBootManagerLib/BmPerformance.c | 317 ------------------ .../Library/UefiBootManagerLib/InternalBm.h | 17 - .../UefiBootManagerLib/UefiBootManagerLib.inf | 4 +- MdeModulePkg/Universal/BdsDxe/Bds.h | 3 +- MdeModulePkg/Universal/BdsDxe/BdsDxe.inf | 3 +- MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 57 +--- UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c | 131 -------- .../Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf | 3 +- .../Library/GenericBdsLib/BdsBoot.c | 29 +- .../Library/GenericBdsLib/GenericBdsLib.inf | 4 +- .../Library/GenericBdsLib/InternalBdsLib.h | 19 +- .../Library/GenericBdsLib/Performance.c | 358 --------------------- 21 files changed, 90 insertions(+), 1337 deletions(-) delete mode 100644 IntelFrameworkModulePkg/Library/GenericBdsLib/Performance.c delete mode 100644 MdeModulePkg/Library/UefiBootManagerLib/BmPerformance.c delete mode 100644 Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/Performance.c -- 1.9.5.msysgit.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
