Hi Ray,

Please share your comments.


Thanks,
Meenakshi

> -----Original Message-----
> From: Carsey, Jaben [mailto:jaben.car...@intel.com]
> Sent: Friday, February 16, 2018 8:51 PM
> To: Meenakshi Aggarwal <meenakshi.aggar...@nxp.com>; Ni, Ruiyu
> <ruiyu...@intel.com>; edk2-devel@lists.01.org; ler...@redhat.com
> Subject: RE: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> 
> Seems good to me.  I will let Ray review also.
> 
> Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> 
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> > Meenakshi
> > Sent: Friday, February 16, 2018 12:45 AM
> > To: Ni, Ruiyu <ruiyu...@intel.com>; Carsey, Jaben
> > <jaben.car...@intel.com>; edk2-devel@lists.01.org; ler...@redhat.com
> > Subject: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> > Importance: High
> >
> > From: Meenakshi Aggarwal <meenakshi.aggar...@nxp.com>
> >
> > Issue:
> > Reply for first ping packet was getting dropped.
> >
> > Cause:
> > Sometimes reply message comes even before trasmit
> > function returns, hence missing 1st reply
> >
> > Fix:
> > Prepare the TxList before calling Transmit function.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Meenakshi Aggarwal <meenakshi.aggar...@nxp.com>
> > ---
> >  ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> > index bec9535..46ba701 100644
> > --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> > +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> > @@ -784,14 +784,17 @@ PingSendEchoRequest (
> >    }
> >
> >    ASSERT(Private->ProtocolPointers.Transmit != NULL);
> > +
> > +  InsertTailList (&Private->TxList, &TxInfo->Link);
> > +
> >    Status = Private->ProtocolPointers.Transmit (Private->IpProtocol, TxInfo-
> > >Token);
> >
> >    if (EFI_ERROR (Status)) {
> > +    RemoveEntryList (&TxInfo->Link);
> >      PingDestroyTxInfo (TxInfo, Private->IpChoice);
> >      return Status;
> >    }
> >
> > -  InsertTailList (&Private->TxList, &TxInfo->Link);
> >    Private->TxCount++;
> >
> >    return EFI_SUCCESS;
> > --
> > 1.9.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> >
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
> s.01.org%2Fmailman%2Flistinfo%2Fedk2-
> devel&data=02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7C1d7bd63786b
> 044ba3c9508d57550d50a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> %7C636543912439710731&sdata=Bn%2Febt4emmCvayFNmcKCi3xJuFfV52Vq
> 4aQLVSNNti8%3D&reserved=0
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to