Thanks Ray and Laszlo; I think I'd better refine comments and commit message first, or it is rather confusing for review.
I'll send v3 ASAP. Regards, Gary On Thu, Feb 22, 2018 at 11:06:13AM +0100, Laszlo Ersek wrote: > On 02/22/18 07:54, Heyi Guo wrote: > > v2: > > Changs are made according to the discussion on the mailing list, including: > > > > 1. PciRootBridgeIo->Configuration should return CPU view address, as well as > > PciIo->GetBarAttributes, and Translation Offset should be equal to PCI view > > address - CPU view address. > > > 3. PciHostBridge driver internally used Base Address is still based on PCI > > view > > address, and translation offset = CPU view - PCI view, which follows the > > definition in ACPI, and not the same as that in UEFI spec. > > I find these opposite interpretations incredibly confusing. My review > for v2 1/2, point (1) namely, is likely wrong because of this. > > This information absolutely needs to go into the commit message of patch > #1, and also into the code as comments. > > Thanks > Laszlo _______________________________________________ edk2-devel mailing list email@example.com https://lists.01.org/mailman/listinfo/edk2-devel