Two minor comments, with them handled, Reviewed-by: Star Zeng <star.z...@intel.com>.
1. For patch 1 and 2, update 'registers' to 'registered' in the comments for parameters DestinationX/DestinationY/Width/Height of EDKII_GET_BOOT_LOGO2? 2. For patch 3, update 'functionm' to ' function'? Thanks, Star -----Original Message----- From: Kinney, Michael D Sent: Friday, February 16, 2018 6:52 AM To: edk2-devel@lists.01.org Cc: Sean Brogan <sean.bro...@microsoft.com>; Bret Barkelew <bret.barke...@microsoft.com>; Yao, Jiewen <jiewen....@intel.com>; Zeng, Star <star.z...@intel.com>; Dong, Eric <eric.d...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: [Patch v2 0/3] MdeModulePkg: Add Boot Logo 2 Protocol V2: * Make Boot Logo2 Protocol higher priority than Boot Logo Protocol. If both are present, then only use Boot Logo 2 Protocol Branch for review: https://github.com/mdkinney/edk2/tree/Bug_799_BootLogo2Protocol_V4 https://bugzilla.tianocore.org/show_bug.cgi?id=799 Based on content from the following branch/commit: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport https://github.com/Microsoft/MS_UEFI/commit/33bab4031a417d7d5a7d356c15a14c2e60302b2d Add new Boot Logo 2 Protocol that adds a GetBootLogo() service that can be used to retrieve the GOP BLT buffer, location, and size of the boot logo that was previously registered with the SetBootLogo() service. The Boot Logo 2 Protocol service GetBootLogo() is amended to return the pointer to the GOP BLT buffer previously registered with the SetBootLogo() service. Cc: Sean Brogan <sean.bro...@microsoft.com> Cc: Bret Barkelew <bret.barke...@microsoft.com> Cc: Jiewen Yao <jiewen....@intel.com> Cc: Star Zeng <star.z...@intel.com> Cc: Eric Dong <eric.d...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney <michael.d.kin...@intel.com> Kinney, Michael D (2): MdeModulePkg: Add Boot Logo 2 Protocol MdeModulePkg/BootLogoLib: Use Boot Logo 2 Protocol Michael D Kinney (1): MdeModulePkg/BootGraphicsResourceDxe: Add Boot Logo 2 Protocol MdeModulePkg/Include/Protocol/BootLogo2.h | 118 ++++++++++++ MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 32 +++- MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf | 2 + MdeModulePkg/MdeModulePkg.dec | 3 + .../BootGraphicsResourceTableDxe.c | 208 +++++++++++++++++++-- .../BootGraphicsResourceTableDxe.inf | 2 + 6 files changed, 349 insertions(+), 16 deletions(-) create mode 100644 MdeModulePkg/Include/Protocol/BootLogo2.h -- 2.14.2.windows.3 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
