Two minor comments, with them handled, Reviewed-by: Star Zeng <[email protected]>.
1. For patch 1 and 2, update 'registers' to 'registered' in the comments for parameters DestinationX/DestinationY/Width/Height of EDKII_GET_BOOT_LOGO2? 2. For patch 3, update 'functionm' to ' function'? Thanks, Star -----Original Message----- From: Kinney, Michael D Sent: Friday, February 16, 2018 6:52 AM To: [email protected] Cc: Sean Brogan <[email protected]>; Bret Barkelew <[email protected]>; Yao, Jiewen <[email protected]>; Zeng, Star <[email protected]>; Dong, Eric <[email protected]>; Kinney, Michael D <[email protected]> Subject: [Patch v2 0/3] MdeModulePkg: Add Boot Logo 2 Protocol V2: * Make Boot Logo2 Protocol higher priority than Boot Logo Protocol. If both are present, then only use Boot Logo 2 Protocol Branch for review: https://github.com/mdkinney/edk2/tree/Bug_799_BootLogo2Protocol_V4 https://bugzilla.tianocore.org/show_bug.cgi?id=799 Based on content from the following branch/commit: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport https://github.com/Microsoft/MS_UEFI/commit/33bab4031a417d7d5a7d356c15a14c2e60302b2d Add new Boot Logo 2 Protocol that adds a GetBootLogo() service that can be used to retrieve the GOP BLT buffer, location, and size of the boot logo that was previously registered with the SetBootLogo() service. The Boot Logo 2 Protocol service GetBootLogo() is amended to return the pointer to the GOP BLT buffer previously registered with the SetBootLogo() service. Cc: Sean Brogan <[email protected]> Cc: Bret Barkelew <[email protected]> Cc: Jiewen Yao <[email protected]> Cc: Star Zeng <[email protected]> Cc: Eric Dong <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney <[email protected]> Kinney, Michael D (2): MdeModulePkg: Add Boot Logo 2 Protocol MdeModulePkg/BootLogoLib: Use Boot Logo 2 Protocol Michael D Kinney (1): MdeModulePkg/BootGraphicsResourceDxe: Add Boot Logo 2 Protocol MdeModulePkg/Include/Protocol/BootLogo2.h | 118 ++++++++++++ MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 32 +++- MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf | 2 + MdeModulePkg/MdeModulePkg.dec | 3 + .../BootGraphicsResourceTableDxe.c | 208 +++++++++++++++++++-- .../BootGraphicsResourceTableDxe.inf | 2 + 6 files changed, 349 insertions(+), 16 deletions(-) create mode 100644 MdeModulePkg/Include/Protocol/BootLogo2.h -- 2.14.2.windows.3 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
