On 02/27/18 06:19, Jian J Wang wrote: > The field KnownGoodStackTop in CPU_EXCEPTION_INIT_DATA is initialized to > the start address of array mNewStack. This is wrong. It must be the end > of mNewStack. This patch fixes this mistake. > > Cc: Ruiyu Ni <[email protected]> > Cc: Eric Dong <[email protected]> > Cc: Laszlo Ersek <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jian J Wang <[email protected]> > --- > UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeException.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeException.c > b/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeException.c > index 6d1b54d31d..2a090782fc 100644 > --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeException.c > +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeException.c > @@ -270,7 +270,7 @@ InitializeCpuExceptionHandlersEx ( > AsmReadGdtr (&Gdtr); > > EssData.X64.Revision = CPU_EXCEPTION_INIT_DATA_REV; > - EssData.X64.KnownGoodStackTop = (UINTN)mNewStack; > + EssData.X64.KnownGoodStackTop = (UINTN)mNewStack + sizeof > (mNewStack); > EssData.X64.KnownGoodStackSize = CPU_KNOWN_GOOD_STACK_SIZE; > EssData.X64.StackSwitchExceptions = CPU_STACK_SWITCH_EXCEPTION_LIST; > EssData.X64.StackSwitchExceptionNumber = > CPU_STACK_SWITCH_EXCEPTION_NUMBER; >
Can you add the following to the commit message? Fixes: 0ff5aa9cae1ea276668fa4398d047aa9fda3c2c7 With that, Reviewed-by: Laszlo Ersek <[email protected]> Thanks Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
