Reviewed-by: Liming Gao <[email protected]>
> -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of Ruiyu > Ni > Sent: Friday, March 2, 2018 7:52 PM > To: [email protected] > Subject: [edk2] [PATCH 1/2] MdePkg/DevicePathFromText: Fix bug when > converting iSCSI node > > If protocol string is not specified, default TCP(0) should be used. > Today's implementation wrongly sets to 1 for this case. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni <[email protected]> > Cc: Yonghong Zhu <[email protected]> > --- > MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c > b/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c > index 0459f0ab25..c66b77ba6c 100644 > --- a/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c > +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c > @@ -1,7 +1,7 @@ > /** @file > DevicePathFromText protocol as defined in the UEFI 2.0 specification. > > -Copyright (c) 2013 - 2017, Intel Corporation. All rights reserved.<BR> > +Copyright (c) 2013 - 2018, Intel Corporation. All rights reserved.<BR> > This program and the accompanying materials > are licensed and made available under the terms and conditions of the BSD > License > which accompanies this distribution. The full text of the license may be > found at > @@ -2581,7 +2581,7 @@ DevPathFromTextiSCSI ( > > ISCSIDevPath->LoginOption = (UINT16) Options; > > - if (StrCmp (ProtocolStr, L"TCP") == 0) { > + if (IS_NULL (*ProtocolStr) || (StrCmp (ProtocolStr, L"TCP") == 0)) { > ISCSIDevPath->NetworkProtocol = 0; > } else { > // > -- > 2.16.1.windows.1 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
